Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Create file and folder structure #1

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

cedricziel
Copy link
Contributor

Leverage typo3-console to create the file and folder structure
through composer events.

This also introduces a hash for common scripts which are needed
by the majority of composer-based TYPO3 projects for plumbing scripts that
need to be executed on the to main events that mutate the library state (install && update)

Can also be invoked manually through composer typo3-cms-scripts.

Should be merged back into the next 8.7 release of the dist.

Leverage typo3-console to create the file and folder structure
through composer events.
@bmack
Copy link
Member

bmack commented Apr 13, 2017

I think flushing cache and set up db structure should be added as well, what do you think?

Could we also describe these actions in the README?

@cedricziel
Copy link
Contributor Author

Well.. Yes and no :)

I think we should only automate the actions that do not require a db connection, so that CI environments don't necessarily require a db connection. - Even composer create-project would fail if no db connection was available whilst executing the scripts.

Flushing the cache is a good idea, as long as it only handles file caches - the reason is that otherwise no mutating operations with composer would be possible anymore since the post-update scripts would fail and the composer transactions would be rolled back.

I think for those, we should define another script such as typo3-fasten-your-seatbelts or typo3-org-is-not-responsible-for-broken-project.

Jokes aside - there are a bunch of other operations that could be potentially useful such as generating the PackageStates from the set of required extensions and running the extension setup for the active extensions, but we should carefully choose which we want. - Symfony has a competitive advantage in the sense that they use https://packagist.org/packages/incenteev/composer-parameter-handler to ask the user about missing parameters so they have at least a good chance of having the database credentials available.

--

I think we should start with the directory structure script and then go from there.

@bmack
Copy link
Member

bmack commented Apr 13, 2017

Agreed :) Let's do separate scripts for "t3-deploy" and "t3-setup" etc.

@bmack bmack merged commit ed0c3fd into TYPO3:master Apr 13, 2017
@cedricziel cedricziel deleted the patch-1 branch April 13, 2017 14:10
@cedricziel
Copy link
Contributor Author

Sounds great - thx for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants