Skip to content

Commit

Permalink
[TASK] Remove not helpful parts from log entries
Browse files Browse the repository at this point in the history
Log entries in the log module show some internal log numbers like `(msg#255.3.2)`
which is neither understandable nor helpful. Therefore this can be
safely removed.

An extra exclamation mark is remove as well as one is enough.

Resolves: #93378
Releases: master
Change-Id: Iffd92766deb0e733da67105811d43ef2851489d5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67545
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Richard Haeser <richard@richardhaeser.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Richard Haeser <richard@richardhaeser.com>
  • Loading branch information
georgringer authored and haassie committed Jan 29, 2021
1 parent 5bfb9b2 commit 011f837
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -207,9 +207,6 @@ <h3>
</td>
<td class="col-word-break">
<belog:formatDetails logEntry="{logItem}"/>
<f:if condition="{logItem.detailsNumber} > 0">
(msg#{logItem.type}.{logItem.action}.{logItem.detailsNumber})
</f:if>
</td>
<td>
<f:if condition="{logItem.error} == 1">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function getUser()
$user = $this->fetchUserRecord($this->login['uname']);
if (!is_array($user)) {
// Failed login attempt (no username found)
$this->writelog(SystemLogType::LOGIN, SystemLogLoginAction::ATTEMPT, SystemLogErrorClassification::SECURITY_NOTICE, 2, 'Login-attempt from ###IP###, username \'%s\' not found!!', [$this->login['uname']]);
$this->writelog(SystemLogType::LOGIN, SystemLogLoginAction::ATTEMPT, SystemLogErrorClassification::SECURITY_NOTICE, 2, 'Login-attempt from ###IP###, username \'%s\' not found!', [$this->login['uname']]);
$this->logger->info('Login-attempt from username \'' . $this->login['uname'] . '\' not found!', [
'REMOTE_ADDR' => $this->authInfo['REMOTE_ADDR']
]);
Expand Down

0 comments on commit 011f837

Please sign in to comment.