Skip to content

Commit

Permalink
[TASK] Skip SVG sanitizer test causing segmentation fault
Browse files Browse the repository at this point in the history
SVG sanitizer test dataset entity.svg is causing segmentation fault
in certain scenarios - which might be related to libxml2 before
version 2.9.12. Unfortunately, investigations did not reveal any
further details other than libxml2.

As a result `entity.svg` test dataset, which is causing this problem is
skipped until darylldoyle/svg-sanitizer#53 is
merged and released in the upstream library.

Resolves: #94565
Releases: master, 10.4, 9.5
Change-Id: I8375954dad64e3955f88122fa51dca7f796d077b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69975
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
  • Loading branch information
ohader committed Jul 20, 2021
1 parent 7998a24 commit 0c78fae
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ public function svgContentIsSanitizedDataProvider(): array
*/
public function svgContentIsSanitized($filePath, $sanitizedFilePath)
{
// @todo re-enable test once https://github.com/darylldoyle/svg-sanitizer/pull/53 is merged
if ($filePath === 'DirtySVG/entity.svg') {
self::markTestSkipped('Skipped due experienced segmentation faults');
}
$basePath = dirname(__FILE__, 2) . '/Fixtures/';
$sanitizer = new SvgSanitizer();
self::assertStringEqualsFile(
Expand Down

0 comments on commit 0c78fae

Please sign in to comment.