-
Notifications
You must be signed in to change notification settings - Fork 653
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUGFIX] Exclude logger from serialize on save for scheduler task
Exclusion of the logger instance from the record during save to database. Prevent hard-coded logfile paths in database record. Set the logger at runtime if the task is executed. Resolves: #86785 Releases: master, 9.5 Change-Id: I30cf258042a2ca6ec3e79a52dcf3a3849cfbe77d Reviewed-on: https://review.typo3.org/59237 Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: TYPO3com <no-reply@typo3.com> Reviewed-by: Chris Müller <typo3@krue.ml> Tested-by: Chris Müller <typo3@krue.ml> Reviewed-by: Benni Mack <benni@typo3.org> Tested-by: Benni Mack <benni@typo3.org>
- Loading branch information
Showing
2 changed files
with
48 additions
and
0 deletions.
There are no files selected for viewing
24 changes: 24 additions & 0 deletions
24
...ation/Changelog/9.5.x/Important-86785-CallingSchedulerTaskThrowsLoggerError.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
.. include:: ../../Includes.txt | ||
|
||
========================================================================================= | ||
Important: #86785 - Calling scheduler command on CLI throws error if not in /var/www/html | ||
========================================================================================= | ||
|
||
See :issue:`86785` | ||
|
||
Description | ||
=========== | ||
|
||
Calling the scheduler command on CLI or in backend throws an error, if the TYPO3 CMS installation is not running in @/var/www/html/@. | ||
|
||
After saving the scheduler task, the logger instance is serialized to the database with absolute paths (FileWriter::class). | ||
Exclusion of the logger instance from the record during save to database. | ||
|
||
Impact | ||
====== | ||
|
||
The stored and serialized tasks from upgraded TYPO3 instances and new saved tasks still work as before. | ||
The logger instance is initialized while running the scheduler task and is not saved to the serialized task | ||
object anymore. The logger (FileWriter::class) can open and write the log file to the current environment paths. | ||
|
||
.. index:: Backend, ext:scheduler, NotScanned |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters