Skip to content

Commit

Permalink
[TASK] Separate restore from delete in DataHandler
Browse files Browse the repository at this point in the history
The DataHandler delete related methods still handle
too many things.
This is yet another divide & conquer patch: Move
the 'undelete' functionality to dedicated methods,
drop handling from 'delete' methods and refactor
'undelete'.
The result is a quite straight forward 'undelete'
implementation, plus reduced complexity in 'delete'.

Change-Id: I6ea2326fa2ad6de03c8cd3bd37184fff116fda06
Resolves: #93253
Releases: master
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67368
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
  • Loading branch information
lolli42 authored and bmack committed Jan 11, 2021
1 parent b66d495 commit 67ad9d7
Show file tree
Hide file tree
Showing 2 changed files with 186 additions and 80 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,7 @@ public function checkFullLanguagesAccess($table, $record)
* @return bool TRUE if OK, otherwise FALSE
* @internal should only be used from within TYPO3 Core
*/
public function recordEditAccessInternals($table, $idOrRow, $newRecord = false, $deletedRecord = false, $checkFullLanguageAccess = false)
public function recordEditAccessInternals($table, $idOrRow, $newRecord = false, $deletedRecord = false, $checkFullLanguageAccess = false): bool
{
if (!isset($GLOBALS['TCA'][$table])) {
return false;
Expand Down
Loading

0 comments on commit 67ad9d7

Please sign in to comment.