Skip to content

Commit

Permalink
[BUGFIX] Re-add proper badges for toolbar items
Browse files Browse the repository at this point in the history
The opendocs toolbar item does not have a badge background anymore,
this changes re-adds the background and also unifies
the badge from the system information toolbar to use
the rounded-pill class.

Resolves: #93303
Releases: master
Change-Id: Ie2ecc99fd5ad4ad8845923af018c051665ac6118
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67459
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
  • Loading branch information
bmack authored and lolli42 committed Jan 18, 2021
1 parent 7608be0 commit 7a2fd02
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class SystemInformationMenu {
// ensure all default classes are available and previous
// (at this time in processing unknown) class is removed
$counter.removeClass();
$counter.addClass('t3js-systeminformation-counter toolbar-item-badge badge');
$counter.addClass('t3js-systeminformation-counter toolbar-item-badge badge rounded-pill');
// badgeClass e.g. could be 'badge-info', 'badge-danger', ...
if (badgeClass !== '') {
$counter.addClass(badgeClass);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
title: 'LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:toolbarItems.sysinfo',
icon: '{core:icon(identifier: \'actions-system-list-open\', size: \'small\', alternativeMarkupIdentifier: \'inline\')}'
}" />
<span class="toolbar-item-badge t3js-systeminformation-counter badge"></span>
<span class="toolbar-item-badge t3js-systeminformation-counter badge rounded-pill bg-warning"></span>
</html>

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
<core:icon identifier="apps-toolbar-menu-opendocs" alternativeMarkupIdentifier="inline"/>
</span>
<span class="toolbar-item-title">{f:translate(key: 'toolbaritem', extensionName: 'opendocs')}</span>
<span class="toolbar-item-badge badge" id="tx-opendocs-counter"></span>
<span class="toolbar-item-badge badge rounded-pill bg-primary" id="tx-opendocs-counter"></span>
</html>

0 comments on commit 7a2fd02

Please sign in to comment.