Skip to content

Commit

Permalink
[!!!][TASK] Remove deprecated icon identifiers
Browse files Browse the repository at this point in the history 
Resolves: #91740
Releases: master
Change-Id: Ie728f74bd45f7e427f4f2242778257320eac5ef7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64995
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
  • Loading branch information
@andreaskienast @bmack
andreaskienast authored and bmack committed Jul 20, 2020
1 parent 36aee73 commit 82c19f6
Show file tree
Hide file tree
Showing 70 changed files with 295 additions and 212 deletions.
51 changes: 2 additions & 49 deletions typo3/sysext/core/Classes/Imaging/IconRegistry.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -395,56 +395,9 @@ class IconRegistry implements SingletonInterface
* ]
*
* @var array
* @deprecated These icons will be removed in TYPO3 v12
*/
protected $deprecatedIcons = [
'module-web' => 'modulegroup-web',
'module-site' => 'modulegroup-site',
'module-file' => 'modulegroup-file',
'module-tools' => 'modulegroup-tools',
'module-system' => 'modulegroup-system',
'module-help' => 'modulegroup-help',
'module-workspaces-action-preview-link' => 'actions-version-workspaces-preview-link',
'generate-ws-preview-link' => 'actions-version-workspaces-preview-link',
'extensions-workspaces-generatepreviewlink' => 'actions-version-workspaces-preview-link',
'extensions-extensionmanager-update-script' => 'actions-refresh',
'extensions-scheduler-run-task' => 'actions-play',
'extensions-scheduler-run-task-cron' => 'actions-clock',
'status-warning-lock' => 'warning-lock',
'status-warning-in-use' => 'warning-in-use',
'status-status-reference-hard' => 'status-reference-hard',
'status-status-reference-soft' => 'status-reference-soft',
'status-status-edit-read-only' => 'status-edit-read-only',
't3-form-icon-advanced-password' => 'form-advanced-password',
't3-form-icon-checkbox' => 'form-checkbox',
't3-form-icon-content-element' => 'form-content-element',
't3-form-icon-date-picker' => 'form-date-picker',
't3-form-icon-duplicate' => 'actions-duplicate',
't3-form-icon-email' => 'form-email',
't3-form-icon-fieldset' => 'form-fieldset',
't3-form-icon-file-upload' => 'form-file-upload',
't3-form-icon-finisher' => 'form-finisher',
't3-form-icon-form-element-selector' => 'actions-variable-select',
't3-form-icon-gridcontainer' => 'form-gridcontainer',
't3-form-icon-gridrow' => 'form-gridrow',
't3-form-icon-hidden' => 'form-hidden',
't3-form-icon-image-upload' => 'form-image-upload',
't3-form-icon-insert-after' => 'actions-form-insert-after',
't3-form-icon-insert-in' => 'actions-form-insert-in',
't3-form-icon-multi-checkbox' => 'form-multi-checkbox',
't3-form-icon-multi-select' => 'form-multi-select',
't3-form-icon-number' => 'form-number',
't3-form-icon-page' => 'form-page',
't3-form-icon-password' => 'form-password',
't3-form-icon-radio-button' => 'form-radio-button',
't3-form-icon-single-select' => 'form-single-select',
't3-form-icon-static-text' => 'form-static-text',
't3-form-icon-summary-page' => 'form-summary-page',
't3-form-icon-telephone' => 'form-telephone',
't3-form-icon-text' => 'form-text',
't3-form-icon-textarea' => 'form-textarea',
't3-form-icon-url' => 'form-url',
't3-form-icon-validator' => 'form-validator',
];
protected $deprecatedIcons = [];

/**
* @var string
Expand Down
130 changes: 130 additions & 0 deletions ...cumentation/Changelog/master/Breaking-91740-DeprecatedIconIdentifierRemoved.rst
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
.. include:: ../../Includes.txt

=====================================================
Breaking: #91740 - Deprecated icon identifier removed
=====================================================

See :issue:`91740`

Description
===========

The following deprecated icon identifiers have been removed from the Icon API:

+-------------------------------------------+-------------------------------------------+
| Deprecated identifier | New identifier |
+===========================================+===========================================+
| module-web | modulegroup-web' |
+-------------------------------------------+-------------------------------------------+
| module-site | modulegroup-site' |
+-------------------------------------------+-------------------------------------------+
| module-file | modulegroup-file' |
+-------------------------------------------+-------------------------------------------+
| module-tools | modulegroup-tools' |
+-------------------------------------------+-------------------------------------------+
| module-system | modulegroup-system' |
+-------------------------------------------+-------------------------------------------+
| module-help | modulegroup-help' |
+-------------------------------------------+-------------------------------------------+
| module-workspaces-action-preview-link | actions-version-workspaces-preview-link' |
+-------------------------------------------+-------------------------------------------+
| generate-ws-preview-link | actions-version-workspaces-preview-link' |
+-------------------------------------------+-------------------------------------------+
| extensions-workspaces-generatepreviewlink | 'actions-version-workspaces-preview-link' |
+-------------------------------------------+-------------------------------------------+
| extensions-extensionmanager-update-script | 'actions-refresh' |
+-------------------------------------------+-------------------------------------------+
| extensions-scheduler-run-task | actions-play' |
+-------------------------------------------+-------------------------------------------+
| extensions-scheduler-run-task-cron | actions-clock' |
+-------------------------------------------+-------------------------------------------+
| status-warning-lock | warning-lock' |
+-------------------------------------------+-------------------------------------------+
| status-warning-in-use | warning-in-use' |
+-------------------------------------------+-------------------------------------------+
| status-status-reference-hard | status-reference-hard' |
+-------------------------------------------+-------------------------------------------+
| status-status-reference-soft | status-reference-soft' |
+-------------------------------------------+-------------------------------------------+
| status-status-edit-read-only | status-edit-read-only' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-advanced-password | form-advanced-password' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-checkbox | form-checkbox' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-content-element | form-content-element' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-date-picker | form-date-picker' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-duplicate | actions-duplicate' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-email | form-email' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-fieldset | form-fieldset' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-file-upload | form-file-upload' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-finisher | form-finisher' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-form-element-selector | actions-variable-select' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-gridcontainer | form-gridcontainer' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-gridrow | form-gridrow' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-hidden | form-hidden' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-image-upload | form-image-upload' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-insert-after | actions-form-insert-after' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-insert-in | actions-form-insert-in' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-multi-checkbox | form-multi-checkbox' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-multi-select | form-multi-select' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-number | form-number' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-page | form-page' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-password | form-password' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-radio-button | form-radio-button' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-single-select | form-single-select' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-static-text | form-static-text' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-summary-page | form-summary-page' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-telephone | form-telephone' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-text | form-text' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-textarea | form-textarea' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-url | form-url' |
+-------------------------------------------+-------------------------------------------+
| t3-form-icon-validator | form-validator' |
+-------------------------------------------+-------------------------------------------+

Impact
======

Loading any removed icon will result in getting the icon identifier
`default-not-found`.


Affected Installations
======================

All installations using these deprecated icons are affected.


Migration
=========

Use the icon identifiers as listed in the table above.

.. index:: Backend, PHP-API, NotScanned, ext:core
Loading

0 comments on commit 82c19f6

Please sign in to comment.