-
Notifications
You must be signed in to change notification settings - Fork 653
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUGFIX] Run tests with configured error reporting in PHPunit
SystemEnvironmentBuilder calls error_reporting(E_ALL & ~(E_STRICT | E_NOTICE | E_DEPRECATED)); which in turn is called on every test to setup the environment. This basically enforces this exact error reporting and does not allow to configure the error reporting in phpunit.xml AT ALL. Until TYPO3 v9, this was covered in each BaseTestCase in setUpBeforeClass() to re-add E_NOTICE to make all tests run without notice. The functionality in SystemEnvironmentBuilder was added in TYPO3 v6.0 while refactoring TYPO3's Bootstrap to ensure that no notices in ext_localconf.php or ext_tables.php were breaking the output. However, nowadays, TYPO3's error reporting is set up directly after LocalConfiguration.php inclusion, making this logic obsolete. The functionality is therefore moved to the Bootstrap at a later point, which is called for Functional and Acceptance Tests. Resolves: #90125 Releases: master Change-Id: I8d6348ffbf6622c03abecedc1cb0ce286ba1044c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62926 Reviewed-by: Oliver Hader <oliver.hader@typo3.org> Reviewed-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by: Benni Mack <benni@typo3.org> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by: Benni Mack <benni@typo3.org>
- Loading branch information
Showing
4 changed files
with
25 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters