-
Notifications
You must be signed in to change notification settings - Fork 653
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[!!!][TASK] Use no-cookie domain for youtube by default
Improve the privacy of users by using the no-cookie domain of youtube by default and just use youtube.com if explicitly set. Resolves: #84843 Releases: master, 8.7, 7.6 Change-Id: I01472f93e32c2011b5494c4670d07f29348016c3 Reviewed-on: https://review.typo3.org/56880 Tested-by: TYPO3com <no-reply@typo3.com> Reviewed-by: Frank Naegler <frank.naegler@typo3.org> Tested-by: Frank Naegler <frank.naegler@typo3.org> Reviewed-by: Markus Klein <markus.klein@typo3.org> Tested-by: Markus Klein <markus.klein@typo3.org> Reviewed-by: Jan Helke <typo3@helke.de> Tested-by: Jan Helke <typo3@helke.de> Reviewed-by: Frans Saris <franssaris@gmail.com> Reviewed-by: Daniel Sattler <sattler@b13.de> Tested-by: Daniel Sattler <sattler@b13.de> Reviewed-by: Benni Mack <benni@typo3.org> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de> Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
- Loading branch information
1 parent
6907f9a
commit b97ba81
Showing
5 changed files
with
92 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
...tation/Changelog/7.6.x/Breaking-84843-UseNo-cookieDomainForYoutubeByDefault.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
.. include:: ../../Includes.txt | ||
|
||
============================================================== | ||
Breaking: #84843 - Use no-cookie domain for youtube by default | ||
============================================================== | ||
|
||
See :issue:`84843` | ||
|
||
Description | ||
=========== | ||
|
||
To improve the privacy of users the renderer for YouTube videos has been changed to use | ||
the no-cookie domain `www.youtube-nocookie.com` by default. The regular domain `www.youtube.com` | ||
is used if explicitly set by the following TypoScript configuration: | ||
|
||
.. code-block:: typoscript | ||
lib.contentElement { | ||
settings { | ||
media { | ||
additionalConfig { | ||
no-cookie = 0 | ||
} | ||
} | ||
} | ||
} | ||
Impact | ||
====== | ||
|
||
The TypoScript configuration :ts:`lib.contentElement.settings.media.additionalConfig` is used | ||
as attribute :php:`additionalConfig` of the ViewHelper :php:`\TYPO3\CMS\Fluid\ViewHelpers\MediaViewHelper`. | ||
|
||
If no configuration is provided, the domain `www.youtube-nocookie.com` is used. | ||
|
||
|
||
Affected Installations | ||
====================== | ||
|
||
Installations which require the usage of the domain `www.youtube.com` or setting cookies by YouTube. | ||
|
||
|
||
Migration | ||
========= | ||
|
||
Use the TypoScript configuration :ts:`lib.contentElement.settings.media.additionalConfig.no-cookie = 0` | ||
|
||
.. index:: TypoScript, ext:fluid_styled_content |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
typo3/sysext/fluid_styled_content/Resources/Private/Partials/Media/Rendering/Video.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" data-namespace-typo3-fluid="true"> | ||
<f:media class="video-embed-item" file="{file}" width="{dimensions.width}" height="{dimensions.height}" alt="{file.alternative}" title="{file.title}" /> | ||
<f:media class="video-embed-item" file="{file}" width="{dimensions.width}" height="{dimensions.height}" alt="{file.alternative}" title="{file.title}" additionalConfig="{settings.media.additionalConfig}" /> | ||
</html> |