Skip to content

Commit

Permalink
[BUGFIX] Do not compress inline CSS
Browse files Browse the repository at this point in the history
Gzip encoding inline CSS does not work and we should not do that.
Therefor setting `inline = 1` now also implies `disableCompression`
(same way as it is done for concatenation).

Resolves: #90820
Releases: master, 9.5
Change-Id: I85c70bba9dd850fe9b03086dc6c51f7064c60ba7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63865
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
  • Loading branch information
susannemoog authored and andreaskienast committed Mar 24, 2020
1 parent 9548679 commit c2be7f2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions typo3/sysext/frontend/Classes/Http/RequestHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ protected function generatePageContentWithHeader(TypoScriptFrontendController $c
$cssFileConfig['alternate'] ? 'alternate stylesheet' : 'stylesheet',
$cssFileConfig['media'] ?: 'all',
$cssFileConfig['title'] ?: '',
$cssFileConfig['external'] ? false : empty($cssFileConfig['disableCompression']),
$cssFileConfig['external'] || (bool)$cssFileConfig['inline'] ? false : empty($cssFileConfig['disableCompression']),
(bool)$cssFileConfig['forceOnTop'],
$cssFileConfig['allWrap'],
(bool)$cssFileConfig['excludeFromConcatenation'] || (bool)$cssFileConfig['inline'],
Expand Down Expand Up @@ -533,7 +533,7 @@ protected function generatePageContentWithHeader(TypoScriptFrontendController $c
$cssFileConfig['alternate'] ? 'alternate stylesheet' : 'stylesheet',
$cssFileConfig['media'] ?: 'all',
$cssFileConfig['title'] ?: '',
$cssFileConfig['external'] ? false : empty($cssFileConfig['disableCompression']),
$cssFileConfig['external'] || (bool)$cssFileConfig['inline'] ? false : empty($cssFileConfig['disableCompression']),
(bool)$cssFileConfig['forceOnTop'],
$cssFileConfig['allWrap'],
(bool)$cssFileConfig['excludeFromConcatenation'] || (bool)$cssFileConfig['inline'],
Expand Down

0 comments on commit c2be7f2

Please sign in to comment.