Skip to content

Commit

Permalink
[TASK] Remove jQuery from Permissions module
Browse files Browse the repository at this point in the history
The Permissions backend module and its JavaScript module now ditch jQuery
in favor of native browser API and TYPO3 API.

The JavaScript has been refactored a little bit; initially checking the
permission checkboxes or writing back the calculcated permission value
is now decoupled and executed in the Permission module only.

To support for..of with NodeList collections, TypeScript now loads the
internal "dom.iterable" library.

Additionally, the interim solution to add `editform` to Document has
been removed which made another change in LinkPopup necessary.

Furthermore, a bug has been fixed, where the value of the first
visible select element was used when saving any other select element
with a completely different value.

Resolves: #93301
Releases: master
Change-Id: Iffede862a0eb36e805a5f127d7b19f32c899ce31
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67457
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>
  • Loading branch information
andreaskienast authored and bmack committed Jan 19, 2021
1 parent af8635d commit e85c0b2
Show file tree
Hide file tree
Showing 6 changed files with 199 additions and 184 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class LinkPopup {

const itemName = this.controlElement.dataset.itemName;
const url = this.controlElement.getAttribute('href')
+ '&P[currentValue]=' + encodeURIComponent(document.editform[itemName].value)
+ '&P[currentValue]=' + encodeURIComponent(document.forms.namedItem('editform')[itemName].value)
+ '&P[currentSelectedValues]=' + encodeURIComponent(FormEngine.getFieldElement(itemName).val());

Modal.advanced({
Expand Down
Loading

0 comments on commit e85c0b2

Please sign in to comment.