Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting warnings if $this->aliasMap['classNameToAliasMapping'][$originalClassName] is not iterable #21

Open
sabbelasichon opened this issue Apr 21, 2021 · 2 comments
Open

Getting warnings if $this->aliasMap['classNameToAliasMapping'][$originalClassName] is not iterable #21

sabbelasichon opened this issue Apr 21, 2021 · 2 comments

Comments

@sabbelasichon
Copy link

When i am running typo3-rector with highest error level i am getting warnings with message "Warning: Invalid argument supplied for foreach() in ClassAliasLoader.php on line 186".

I cannot tell what´s the root of the problem or why stepping into the foreach anyways. But maybe it is safe to check if $this->aliasMap['classNameToAliasMapping'][$originalClassName] is iterable.
sabbelasichon added a commit to sabbelasichon/class-alias-loader that referenced this issue Apr 21, 2021
@sabbelasichon
[BUGFIX] Safety check for foreach
231c2f6 
Resolves: TYPO3#21
@sabbelasichon sabbelasichon mentioned this issue Apr 21, 2021
Closed
sabbelasichon added a commit to sabbelasichon/class-alias-loader that referenced this issue Apr 22, 2021
@sabbelasichon
[BUGFIX] Safety check for foreach
4e0b2a1 
Resolves: TYPO3#21
@helhum
Copy link
Contributor

helhum commented Aug 7, 2022

Fixed with #20

@hdietrich-timespin
Copy link

Fixed with #20

No is not fixed.

The function TYPO3\ClassAliasLoader::loadOriginalClassAndSetAliases($originalClassName) don't use the fixed function TYPO3\ClassAliasLoader::getOriginalClassName($aliasOrClassName). And so the Issue #22 and #21 is not solved!

@hdietrich-timespin hdietrich-timespin mentioned this issue Nov 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Safety check for foreach sabbelasichon/class-alias-loader
3 participants
@helhum @sabbelasichon @hdietrich-timespin