Skip to content

Commit

Permalink
[BUGFIX] Clean up VersionServiceTest
Browse files Browse the repository at this point in the history
- replace the bogus `$this::assert*` with `self::assert*`
  (this fixes the CS fixer warnings)
- fix a typo in test names
  • Loading branch information
oliverklee committed Aug 16, 2021
1 parent 7784818 commit e6ddac5
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions tests/Unit/Service/VersionServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ class VersionServiceTest extends TestCase
/**
* @test
*/
public function defaultExcludeFromPackagingConfiurationIsUsedOnNonExistingEnvVar(): void
public function defaultExcludeFromPackagingConfigurationIsUsedOnNonExistingEnvVar(): void
{
unset($_ENV);

$this::assertContains(
self::assertContains(
'vendor',
$this->invokeMethod('getExcludeConfiguration', [])['directories']
);
Expand All @@ -35,13 +35,13 @@ public function defaultExcludeFromPackagingConfiurationIsUsedOnNonExistingEnvVar
/**
* @test
*/
public function defaultExcludeFromPackagingConfiurationIsUsedOnEmptyPath(): void
public function defaultExcludeFromPackagingConfigurationIsUsedOnEmptyPath(): void
{
unset($_ENV);
putenv('TYPO3_EXCLUDE_FROM_PACKAGING=');
$_ENV['TYPO3_EXCLUDE_FROM_PACKAGING'] = '';

$this::assertContains(
self::assertContains(
'vendor',
$this->invokeMethod('getExcludeConfiguration', [])['directories']
);
Expand All @@ -50,13 +50,13 @@ public function defaultExcludeFromPackagingConfiurationIsUsedOnEmptyPath(): void
/**
* @test
*/
public function customExcludeFromPackagingConfiurationIsUsed(): void
public function customExcludeFromPackagingConfigurationIsUsed(): void
{
unset($_ENV);
putenv('TYPO3_EXCLUDE_FROM_PACKAGING=');
$_ENV['TYPO3_EXCLUDE_FROM_PACKAGING'] = __DIR__ . '/../Fixtures/ExcludeFromPackaging/config_valid.php';

$this::assertSame(
self::assertSame(
['directories' => ['dummy'], 'files' => ['dummy']],
$this->invokeMethod('getExcludeConfiguration', [])
);
Expand Down Expand Up @@ -98,7 +98,7 @@ public function getVersionFilenameTest(): void
unset($_ENV);
putenv('TYPO3_EXCLUDE_FROM_PACKAGING=' . __DIR__ . '/../Fixtures/ExcludeFromPackaging/config_valid.php');

$this::assertSame(
self::assertSame(
'/dummyPath/my_ext_1.0.0.zip',
$this->invokeMethod('getVersionFilename', [])
);
Expand All @@ -113,7 +113,7 @@ public function getVersionFilenameAsMd5Test(): void
putenv('TYPO3_EXCLUDE_FROM_PACKAGING=');
$_ENV['TYPO3_EXCLUDE_FROM_PACKAGING'] = __DIR__ . '/../Fixtures/ExcludeFromPackaging/config_valid.php';

$this::assertSame(
self::assertSame(
'cf2d6e211e53d983056761055c95791b',
$this->invokeMethod('getVersionFilename', [true])
);
Expand Down

0 comments on commit e6ddac5

Please sign in to comment.