Skip to content

Commit

Permalink
[TASK] Fix PHPStan errors in JavaScript module classes
Browse files Browse the repository at this point in the history
Releases: main, 11.5
Resolves: #96707
Change-Id: I0d5808a48d8ed56d5688235feeb465499dd74c5b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73247
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
  • Loading branch information
bnf committed Jan 31, 2022
1 parent 3e7372c commit 1dafc1e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 0 additions & 5 deletions Build/phpstan/phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -1685,11 +1685,6 @@ parameters:
count: 2
path: ../../typo3/sysext/core/Classes/Package/PackageManager.php

-
message: "#^Method TYPO3\\\\CMS\\\\Core\\\\Page\\\\JavaScriptModuleInstruction\\:\\:forRequireJS\\(\\) should return static\\(TYPO3\\\\CMS\\\\Core\\\\Page\\\\JavaScriptModuleInstruction\\) but returns object\\.$#"
count: 1
path: ../../typo3/sysext/core/Classes/Page/JavaScriptModuleInstruction.php

-
message: "#^Property TYPO3\\\\CMS\\\\Core\\\\Page\\\\PageRenderer\\:\\:\\$charSet \\(string\\) in isset\\(\\) is not nullable\\.$#"
count: 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class JavaScriptModuleInstruction implements \JsonSerializable
/**
* @param string $name RequireJS module name
* @param string|null $exportName (optional) name used internally to export the module
* @return static
* @return self
*/
public static function forRequireJS(string $name, string $exportName = null): self
{
Expand Down

0 comments on commit 1dafc1e

Please sign in to comment.