[TASK] Make TableBuilderTest notice free

Resolves: #84444 Releases: master Change-Id: Ie0de790d7c02b0ac4665daf1a4c9a52e912ac9d2 Reviewed-on: https://review.typo3.org/56323 Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by: TYPO3com <no-reply@typo3.com> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
TYPO3 · Mar 17, 2018 · 264c5e0 · 264c5e0
1 parent 277dbe8
commit 264c5e0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/typo3/sysext/core/Classes/Database/Schema/SqlReader.php b/typo3/sysext/core/Classes/Database/Schema/SqlReader.php
@@ -92,7 +92,7 @@ public function getStatementArray(string $dumpContent, string $queryRegex = null
                 continue;
             }
 
-            $statementArray[$statementArrayPointer] .= $lineContent;
+            $statementArray[$statementArrayPointer] = ($statementArray[$statementArrayPointer] ?? '') . $lineContent;
 
             if (substr($lineContent, -1) === ';') {
                 $statement = trim($statementArray[$statementArrayPointer]);

diff --git a/typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php b/typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php
@@ -25,17 +25,13 @@
 use TYPO3\CMS\Core\Database\Schema\Parser\Parser;
 use TYPO3\CMS\Core\Database\Schema\SqlReader;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
+use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
 /**
  * Tests for TableBuilder
  */
-class TableBuilderTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
+class TableBuilderTest extends UnitTestCase
 {
-    /**
-     * Subject is not notice free, disable E_NOTICES
-     */
-    protected static $suppressNotices = true;
-
     /**
      * @var Table
      */