Skip to content

Commit

Permalink
[TASK] Provide title attribute for iframes
Browse files Browse the repository at this point in the history 
All iframes must contain a description to allow screen
readers to identify the content or purpose of them.

Therefore all iframes are now equipped with a proper
title attribute, describing their content.

Resolves: #92646
Releases: master, 10.4
Change-Id: I6af29e2587f51c3800c8b7590ed91f57e4fafd20
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66235
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Josef Glatz <josefglatz@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josefglatz@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
  • Loading branch information
@o-ba @ervaude
o-ba authored and ervaude committed Oct 21, 2020
1 parent f10d076 commit 34df0fc
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 5 deletions.
4 changes: 2 additions & 2 deletions typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html
View file
Expand Up @@ -10,11 +10,11 @@
<div class="scaffold-content t3js-scaffold-content {f:if(condition: '!{hasModules}', then: 'scaffold-no-modules')}">
<div class="scaffold-content-navigation t3js-scaffold-content-navigation">
<div class="scaffold-content-navigation-component" data-component="typo3-navigationIframe">
<iframe name="nav_frame" src="about:blank" id="typo3-navigationContainerIframe" scrolling="no" class="scaffold-content-navigation-iframe t3js-scaffold-content-navigation-iframe"></iframe>
<iframe name="nav_frame" src="about:blank" id="typo3-navigationContainerIframe" title="{f:translate(key: 'LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:iframe.navFrame')}" scrolling="no" class="scaffold-content-navigation-iframe t3js-scaffold-content-navigation-iframe"></iframe>
</div>
</div>
<div class="scaffold-content-module t3js-scaffold-content-module">
<iframe name="list_frame" id="typo3-contentIframe" scrolling="no" class="scaffold-content-module-iframe t3js-scaffold-content-module-iframe"></iframe>
<iframe name="list_frame" id="typo3-contentIframe" title="{f:translate(key: 'LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:iframe.listFrame')}" scrolling="no" class="scaffold-content-module-iframe t3js-scaffold-content-module-iframe"></iframe>
</div>
<div class="scaffold-content-overlay t3js-scaffold-content-overlay"></div>
</div>
Expand Down
6 changes: 6 additions & 0 deletions typo3/sysext/core/Resources/Private/Language/locallang_core.xlf
View file
Expand Up @@ -1278,6 +1278,12 @@ Do you want to refresh it now?</source>
<trans-unit id="filestorage.invalidpathexception.message" resname="filestorage.invalidpathexception.message">
<source>You entered an invalid path for this File Storage. Note that "../" and "//" are not allowed when using an absolute path.</source>
</trans-unit>
<trans-unit id="iframe.navFrame" resname="iframe.navFrame">
<source>Navigation frame to browse through and select folders</source>
</trans-unit>
<trans-unit id="iframe.listFrame" resname="iframe.listFrame">
<source>List frame (content area) to create and modify pages, content and records</source>
</trans-unit>
</body>
</file>
</xliff>
3 changes: 3 additions & 0 deletions typo3/sysext/viewpage/Resources/Private/Language/locallang.xlf
View file
Expand Up @@ -48,6 +48,9 @@
<trans-unit id="noSiteConfiguration" resname="noSiteConfiguration">
<source>The requested page is missing a valid site configuration.</source>
</trans-unit>
<trans-unit id="iframe.title" resname="iframe.title">
<source>View selected page in different screen resolutions</source>
</trans-unit>
</body>
</file>
</xliff>
2 changes: 1 addition & 1 deletion typo3/sysext/viewpage/Resources/Private/Templates/ViewModule/Show.html
View file
Expand Up @@ -74,7 +74,7 @@
</div>
</div>
<div class="viewpage-resizeable t3js-viewpage-resizeable" style="width:{current.width}px;height:{current.height}px;">
<iframe src="{url}" width="100%" height="100%" id="tx_viewpage_iframe" frameborder="0" border="0"></iframe>
<iframe src="{url}" width="100%" height="100%" id="tx_viewpage_iframe" frameborder="0" border="0" title="{f:translate(key: 'LLL:EXT:viewpage/Resources/Private/Language/locallang.xlf:iframe.title')}"></iframe>
</div>
</div>
</f:if>
Expand Down
6 changes: 6 additions & 0 deletions typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf
View file
Expand Up @@ -341,6 +341,12 @@
<trans-unit id="status.error" resname="status.error">
<source>Error</source>
</trans-unit>
<trans-unit id="iframe.livePreview" resname="iframe.livePreview">
<source>Preview of the live record</source>
</trans-unit>
<trans-unit id="iframe.workspacePreview" resname="iframe.workspacePreview">
<source>Preview of the record in workspace %s</source>
</trans-unit>
</body>
</file>
</xliff>
4 changes: 2 additions & 2 deletions typo3/sysext/workspaces/Resources/Private/Templates/Preview/Index.html
View file
Expand Up @@ -48,9 +48,9 @@
<div role="tabpanel" class="tab-pane active workspaces preview-mode-slider" id="visual">
<div class="t3js-workspace-preview">
<f:if condition="{liveUrl}">
<iframe src="{liveUrl}" style="height: 0px;" id="live-view"></iframe>
<iframe src="{liveUrl}" style="height: 0px;" id="live-view" title="{f:translate(key: 'LLL:EXT:workspaces/Resources/Private/Language/locallang.xlf:iframe.livePreview')}"></iframe>
</f:if>
<iframe src="{wsUrl}" id="workspace-view"></iframe>
<iframe src="{wsUrl}" id="workspace-view" title="{f:translate(key: 'LLL:EXT:workspaces/Resources/Private/Language/locallang.xlf:iframe.workspacePreview', arguments: {0: activeWorkspace})}"></iframe>
</div>
</div>
</div>
Expand Down

0 comments on commit 34df0fc

Please sign in to comment.