Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[TASK] Ensure correct SiteConfiguration in
SlugServiceTest.php
It is possible, that the `SiteConfiguration` is retrieved from the `Dependency Injection container` by code executed before the test releated site configuration is written, which does not reset the instance based `SiteConfiguration->$firstLevelCache` property and later retrieving site configurations using the `SiteFinder`, for example in rootline and other operations, cannot find the test instance configurations. With #103470 this has been mitigated within the `SiteBasedTestTrait`, but `\TYPO3\CMS\Redirects\Tests\Functional\Service\SlugServiceTest` uses direct method for additional site configurations suffering from the very same issue. This change modifies the `SlugServiceTest` to retrieve the `SiteConfiguration` from the `Dependency Injection container` to ensure proper internal cache invalidation for SiteConfig write operations and additionally ensure cache invalidation by calling `SiteFinder->getAllSites(false)`. Resolves: #103471 Related: #103470 Releases: main, 12.4 Change-Id: I27075ad9f5640aaea07df81a97c8b0326fd76003 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83574 Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Garvin Hicking <gh@faktor-e.de> Reviewed-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by: core-ci <typo3@b13.com> Reviewed-by: Benni Mack <benni@typo3.org> Tested-by: Garvin Hicking <gh@faktor-e.de>
- Loading branch information