Skip to content

Commit

Permalink
Fixed bug #15735: FORM content object is susceptible to XSS (thanks t…
Browse files Browse the repository at this point in the history
…o Benjamin Mack)

git-svn-id: https://svn.typo3.org/TYPO3v4/Core/branches/TYPO3_4-3@9785 709f56b5-9817-0410-a4d7-c38de5d9e867
  • Loading branch information
ohader committed Dec 16, 2010
1 parent 3aeb4d8 commit 3c5d152
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* Fixed bug #16590: t3lib_TSparser::checkIncludeLines() does not check files to be included (thanks to Fabrizio Branca)
* Fixed bug #15737: quoteStrForLike does not properly escape strings in sql_mode NO_BACKSLASH_ESCAPES
* Fixed bug #16653: SQL injection problem in class.db_list.inc (thanks to Jigal van Hemert)
* Fixed bug #15735: FORM content object is susceptible to XSS (thanks to Benjamin Mack)

2010-12-01 Oliver Hader <oliver@typo3.org>

Expand Down
3 changes: 2 additions & 1 deletion typo3/sysext/cms/tslib/class.tslib_content.php
Original file line number Diff line number Diff line change
Expand Up @@ -1809,7 +1809,7 @@ function FORM($conf,$formData='') {
}
if ($val && strcspn($val,'#/')) {
// label:
$confData['label'] = trim($parts[0]);
$confData['label'] = t3lib_div::removeXSS(trim($parts[0]));
// field:
$fParts = explode(',',$parts[1]);
$fParts[0]=trim($fParts[0]);
Expand All @@ -1835,6 +1835,7 @@ function FORM($conf,$formData='') {
} else {
$confData['fieldname'] = str_replace(' ','_',trim($typeParts[0]));
}
$confData['fieldname'] = htmlspecialchars($confData['fieldname']);
$fieldCode='';

if ($conf['wrapFieldName']) {
Expand Down

0 comments on commit 3c5d152

Please sign in to comment.