[TASK] Clean-up in site handling

- add void return types
- add access modifiers for constants
- fix some null coalescing
- remove superfluous comments
- add newline before namespace

Resolves: #84662
Releases: master
Change-Id: I1288b27b1edbd99b0624a66a5fb01cd02547b5ec
Reviewed-on: https://review.typo3.org/56602
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>

typo3/sysext/backend/Classes/Configuration/SiteTcaConfiguration.php

@@ -1,5 +1,6 @@
 <?php
 declare(strict_types = 1);
+
 namespace TYPO3\CMS\Backend\Configuration;
 
 /*

typo3/sysext/backend/Classes/Form/FormDataProvider/SiteTcaInline.php

@@ -1,5 +1,6 @@
 <?php
 declare(strict_types = 1);
+
 namespace TYPO3\CMS\Backend\Form\FormDataProvider;
 
 /*
@@ -84,7 +85,7 @@ protected function addInlineFirstPid(array $result): array
             // If the parent is a page, use the uid(!) of the (new?) page as pid for the child records:
             if ($table === 'pages') {
                 $liveVersionId = BackendUtility::getLiveVersionIdOfRecord('pages', $row['uid']);
-                $pid = $liveVersionId === null ? $row['uid'] : $liveVersionId;
+                $pid = $liveVersionId ?? $row['uid'];
             } elseif ($row['pid'] < 0) {
                 $prevRec = BackendUtility::getRecord($table, abs($row['pid']));
                 $pid = $prevRec['pid'];
@@ -256,7 +257,7 @@ protected function compileChild(array $result, string $parentFieldName, int $chi
             'inlineTopMostParentFieldName' => $result['inlineTopMostParentFieldName'] ?: $inlineTopMostParent['field'],
         ];
 
-        if ($parentConfig['foreign_selector'] && $parentConfig['appearance']['useCombination']) {
+        if ($parentConfig['foreign_selector'] && ($parentConfig['appearance']['useCombination'] ?? false)) {
             throw new \RuntimeException('useCombination not implemented in sites module', 1522493097);
         }
         return $formDataCompiler->compile($formDataCompilerInput);

typo3/sysext/backend/Classes/Routing/PageUriBuilder.php

@@ -1,5 +1,6 @@
 <?php
 declare(strict_types = 1);
+
 namespace TYPO3\CMS\Backend\Routing;
 
 /*
@@ -36,12 +37,12 @@ class PageUriBuilder implements SingletonInterface
     /**
      * Generates an absolute URL
      */
-    const ABSOLUTE_URL = 'url';
+    public const ABSOLUTE_URL = 'url';
 
     /**
      * Generates an absolute path
      */
-    const ABSOLUTE_PATH = 'path';
+    public const ABSOLUTE_PATH = 'path';
 
     /**
      * @var SiteFinder

typo3/sysext/core/Classes/Site/Entity/Site.php

@@ -1,5 +1,6 @@
 <?php
 declare(strict_types = 1);
+
 namespace TYPO3\CMS\Core\Site\Entity;
 
 /*
@@ -25,9 +26,9 @@
  */
 class Site
 {
-    const ERRORHANDLER_TYPE_PAGE = 'Page';
-    const ERRORHANDLER_TYPE_FLUID = 'Fluid';
-    const ERRORHANDLER_TYPE_PHP = 'PHP';
+    protected const ERRORHANDLER_TYPE_PAGE = 'Page';
+    protected const ERRORHANDLER_TYPE_FLUID = 'Fluid';
+    protected const ERRORHANDLER_TYPE_PHP = 'PHP';
 
     /**
      * @var string
@@ -186,7 +187,7 @@ public function getErrorHandler(int $type): PageErrorHandlerInterface
                 // Check if the interface is implemented
                 $handler = GeneralUtility::makeInstance($errorHandler['errorPhpClassFQCN'], $type, $errorHandler);
                 if (!($handler instanceof PageErrorHandlerInterface)) {
-                    // throw new exception
+                    // @todo throw new exception
                 }
                 return $handler;
         }

typo3/sysext/core/Classes/Site/Entity/SiteLanguage.php

@@ -1,5 +1,6 @@
 <?php
 declare(strict_types = 1);
+
 namespace TYPO3\CMS\Core\Site\Entity;
 
 /*
@@ -159,7 +160,7 @@ public function __construct(Site $site, int $languageId, string $locale, string
      *
      * @return array
      */
-    public function toArray()
+    public function toArray(): array
     {
         return [
             'languageId' => $this->getLanguageId(),

typo3/sysext/core/Classes/Site/SiteFinder.php

@@ -1,5 +1,6 @@
 <?php
 declare(strict_types = 1);
+
 namespace TYPO3\CMS\Core\Site;
 
 /*
@@ -21,7 +22,6 @@
 use TYPO3\CMS\Core\Database\Query\Restriction\DeletedRestriction;
 use TYPO3\CMS\Core\Exception\SiteNotFoundException;
 use TYPO3\CMS\Core\Site\Entity\Site;
-use TYPO3\CMS\Core\Site\Entity\SiteLanguage;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**
@@ -73,7 +73,6 @@ public function getBaseUris(): array
     {
         $baseUrls = [];
         foreach ($this->sites as $site) {
-            /** @var SiteLanguage $language */
             foreach ($site->getLanguages() as $language) {
                 $baseUrls[$language->getBase()] = $language;
                 if ($language->getLanguageId() === 0) {

typo3/sysext/frontend/Classes/PageErrorHandler/FluidPageErrorHandler.php

@@ -1,5 +1,6 @@
 <?php
 declare(strict_types = 1);
+
 namespace TYPO3\CMS\Frontend\PageErrorHandler;
 
 /*

typo3/sysext/frontend/Classes/PageErrorHandler/PageContentErrorHandler.php

@@ -1,5 +1,6 @@
 <?php
 declare(strict_types = 1);
+
 namespace TYPO3\CMS\Frontend\PageErrorHandler;
 
 /*