[TASK] Remove unused variables throughout core

Due to refactoring or very old code some places in the core define unused variables or variables, which are immediately overridden. They are mostly unnecessary. Even in places, where they might be slightly helpful if defined at the beginning of a function, the benefit doesn't excuse the existence. Resolves: #94528 Releases: master Change-Id: I6071bb0bc96472a4b4b7f679bfabbacfb761f472 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69805 Tested-by: core-ci <typo3@b13.com> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Benni Mack <benni@typo3.org>
TYPO3 · Jul 12, 2021 · 6141e85 · 6141e85
1 parent 4c78f44
commit 6141e85
Show file tree

Hide file tree

Showing 36 changed files with 23 additions and 51 deletions.
diff --git a/typo3/sysext/backend/Classes/Clipboard/Clipboard.php b/typo3/sysext/backend/Classes/Clipboard/Clipboard.php
@@ -1026,7 +1026,7 @@ public function makeDeleteCmdArray($CMD)
      */
     public function makePasteCmdArray_file($ref, $FILE)
     {
-        [$pTable, $pUid] = explode('|', $ref);
+        $pUid = explode('|', $ref)[1];
         $elements = $this->elFromTable('_FILE');
         $mode = $this->currentMode() === 'copy' ? 'copy' : 'move';
         // Traverse elements and make CMD array

diff --git a/typo3/sysext/backend/Classes/Controller/BackendController.php b/typo3/sysext/backend/Classes/Controller/BackendController.php
@@ -437,7 +437,6 @@ protected function handlePageEditing(ServerRequestInterface $request): string
      */
     protected function getStartupModule(ServerRequestInterface $request): array
     {
-        $startModule = null;
         $redirectRoute = $request->getQueryParams()['redirect'] ?? '';
         // Check if the route has been registered
         if ($redirectRoute !== '' && $redirectRoute !== 'main' && isset(GeneralUtility::makeInstance(Router::class)->getRoutes()[$redirectRoute])) {

diff --git a/typo3/sysext/backend/Tests/Unit/Form/NodeFactoryTest.php b/typo3/sysext/backend/Tests/Unit/Form/NodeFactoryTest.php
@@ -20,7 +20,6 @@
 use TYPO3\CMS\Backend\Form\Element\UnknownElement;
 use TYPO3\CMS\Backend\Form\Exception;
 use TYPO3\CMS\Backend\Form\NodeFactory;
-use TYPO3\CMS\Backend\Form\NodeInterface;
 use TYPO3\CMS\Backend\Tests\Unit\Form\Fixtures\NodeFactory\NodeElements\BarElement;
 use TYPO3\CMS\Backend\Tests\Unit\Form\Fixtures\NodeFactory\NodeElements\FooElement;
 use TYPO3\CMS\Backend\Tests\Unit\Form\Fixtures\NodeFactory\NodeResolvers\BarResolver;
@@ -431,7 +430,6 @@ public function createInstantiatesResolverWithHighestPriorityFirstWithOneGivenOr
                 'class' => FooElement::class,
             ],
         ];
-        $mockNode = $this->createMock(NodeInterface::class);
 
         $GLOBALS['TYPO3_CONF_VARS']['SYS']['formEngine']['nodeResolver'] = [
             1433156887 => [

diff --git a/typo3/sysext/core/Classes/Core/Bootstrap.php b/typo3/sysext/core/Classes/Core/Bootstrap.php
@@ -357,8 +357,6 @@ protected static function setDefaultTimezone()
     protected static function initializeErrorHandling()
     {
         static::initializeBasicErrorReporting();
-        $displayErrors = 0;
-        $exceptionHandlerClassName = null;
         $productionExceptionHandlerClassName = $GLOBALS['TYPO3_CONF_VARS']['SYS']['productionExceptionHandler'];
         $debugExceptionHandlerClassName = $GLOBALS['TYPO3_CONF_VARS']['SYS']['debugExceptionHandler'];
 

diff --git a/typo3/sysext/core/Classes/DataHandling/DataHandler.php b/typo3/sysext/core/Classes/DataHandling/DataHandler.php
@@ -906,7 +906,6 @@ public function process_datamap()
                 // Checking access to the record
                 // ******************************
                 $createNewVersion = false;
-                $recordAccess = false;
                 $old_pid_value = '';
                 // Is it a new record? (Then Id is a string)
                 if (!MathUtility::canBeInterpretedAsInteger($id)) {
@@ -5449,7 +5448,6 @@ public function discard(string $table, ?int $uid, array $record = null): void
         }
 
         // Gather versioned record
-        $versionRecord = null;
         if ((int)$record['t3ver_wsid'] === 0) {
             $record = BackendUtility::getWorkspaceVersionOfRecord($userWorkspace, $table, $uid);
         }

diff --git a/typo3/sysext/core/Classes/DataHandling/Localization/DataMapItem.php b/typo3/sysext/core/Classes/DataHandling/Localization/DataMapItem.php
@@ -416,7 +416,7 @@ protected function extractId($idValue)
             return $idValue;
         }
         // @todo Handle if $tableName does not match $this->tableName
-        [$tableName, $id] = BackendUtility::splitTable_Uid($idValue);
+        $id = BackendUtility::splitTable_Uid($idValue)[1];
         return $id;
     }
 

diff --git a/typo3/sysext/core/Classes/DataHandling/SlugHelper.php b/typo3/sysext/core/Classes/DataHandling/SlugHelper.php
@@ -605,7 +605,6 @@ function (array $record) {
      */
     protected function resolveParentPageRecord(int $pid, int $languageId): ?array
     {
-        $parentPageRecord = null;
         $rootLine = BackendUtility::BEgetRootLine($pid, '', true, ['nav_title']);
         $excludeDokTypes = [
             PageRepository::DOKTYPE_SPACER,

diff --git a/typo3/sysext/core/Classes/Database/QueryGenerator.php b/typo3/sysext/core/Classes/Database/QueryGenerator.php
@@ -1661,7 +1661,7 @@ public function getSelectQuery($qString = ''): string
                     $webMountPageTreePrefix = ',';
                 }
                 $webMountPageTree .= $webMountPageTreePrefix
-                    . $this->getTreeList($webMount, 999, $begin = 0, $perms_clause);
+                    . $this->getTreeList($webMount, 999, 0, $perms_clause);
             }
             // createNamedParameter() is not used here because the SQL fragment will only include
             // the :dcValueX placeholder when the query is returned as a string. The value for the

diff --git a/typo3/sysext/core/Classes/Database/QueryView.php b/typo3/sysext/core/Classes/Database/QueryView.php
@@ -1065,7 +1065,7 @@ public function makeValueList($fieldName, $fieldValue, $conf, $table, $splitStri
                                     $webMountPageTreePrefix = ',';
                                 }
                                 $webMountPageTree .= $webMountPageTreePrefix
-                                    . $this->getTreeList($webMount, 999, $begin = 0, $perms_clause);
+                                    . $this->getTreeList($webMount, 999, 0, $perms_clause);
                             }
                             if ($from_table === 'pages') {
                                 $queryBuilder->where(

diff --git a/typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php b/typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php
@@ -928,12 +928,12 @@ protected function migrateUnprefixedRemovedTablesToRenames(SchemaDiff $schemaDif
             $tableDiff = GeneralUtility::makeInstance(
                 TableDiff::class,
                 $removedTable->getQuotedName($this->connection->getDatabasePlatform()),
-                $addedColumns = [],
-                $changedColumns = [],
-                $removedColumns = [],
-                $addedIndexes = [],
-                $changedIndexes = [],
-                $removedIndexes = [],
+                [], // added columns
+                [], // changed columns
+                [], // removed columns
+                [], // added indexes
+                [], // changed indexes
+                [], // removed indexed
                 $this->buildQuotedTable($removedTable)
             );
 
@@ -989,7 +989,7 @@ protected function migrateUnprefixedRemovedFieldsToRenames(SchemaDiff $schemaDif
                     ColumnDiff::class,
                     $removedColumn->getQuotedName($this->connection->getDatabasePlatform()),
                     $renamedColumn,
-                    $changedProperties = [],
+                    [], // changed properties
                     $this->buildQuotedColumn($removedColumn)
                 );
 

diff --git a/typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php b/typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php
@@ -328,7 +328,6 @@ function (IndexColumnName $columnName) {
      */
     protected function getDoctrineColumnTypeName(AbstractDataType $dataType): string
     {
-        $doctrineType = null;
         switch (get_class($dataType)) {
             case TinyIntDataType::class:
                 // TINYINT is MySQL specific and mapped to a standard SMALLINT

diff --git a/typo3/sysext/core/Classes/Database/SoftReferenceIndex.php b/typo3/sysext/core/Classes/Database/SoftReferenceIndex.php
@@ -553,7 +553,7 @@ public function setTypoLinkPartsElement($tLP, &$elements, $content, $idx)
                     // Output content will be the token instead:
                     $content = '{softref:' . $tokenID . '}';
                 } elseif ($tLP['identifier']) {
-                    [$linkHandlerKeyword, $linkHandlerValue] = explode(':', trim($tLP['identifier']), 2);
+                    $linkHandlerValue = explode(':', trim($tLP['identifier']), 2)[1];
                     if (MathUtility::canBeInterpretedAsInteger($linkHandlerValue)) {
                         // Token and substitute value
                         $elements[$tokenID . ':' . $idx]['subst'] = [

diff --git a/typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php b/typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php
@@ -632,7 +632,6 @@ protected function validateMailbox(&$mailbox)
      */
     protected function _validateRouteAddr($route_addr)
     {
-        $route = '';
         $return = [];
         // Check for colon.
         if (strpos($route_addr, ':') !== false) {

diff --git a/typo3/sysext/core/Classes/Mail/TransportFactory.php b/typo3/sysext/core/Classes/Mail/TransportFactory.php
@@ -73,7 +73,6 @@ public function get(array $mailSettings): TransportInterface
             throw new \InvalidArgumentException('Mail transport can not be set to "spool"', 1469363238);
         }
 
-        $transport = null;
         $transportType = isset($mailSettings['transport_spool_type'])
             && !empty($mailSettings['transport_spool_type'])
             ? 'spool' : $mailSettings['transport'];
@@ -190,7 +189,6 @@ public function get(array $mailSettings): TransportInterface
      */
     protected function createSpool(array $mailSettings): DelayedTransportInterface
     {
-        $spool = null;
         switch ($mailSettings['transport_spool_type']) {
             case self::SPOOL_FILE:
                 $path = GeneralUtility::getFileAbsFileName($mailSettings['transport_spool_filepath']);

diff --git a/typo3/sysext/core/Classes/Type/File/ImageInfo.php b/typo3/sysext/core/Classes/Type/File/ImageInfo.php
@@ -117,8 +117,6 @@ protected function getImageSizes()
      */
     protected function extractSvgImageSizes()
     {
-        $imagesSizes = [];
-
         $fileContent = file_get_contents($this->getPathname());
         if ($fileContent === false) {
             return false;

diff --git a/typo3/sysext/core/Tests/Unit/DependencyInjection/ListenerProviderPassTest.php b/typo3/sysext/core/Tests/Unit/DependencyInjection/ListenerProviderPassTest.php
@@ -90,7 +90,7 @@ public function testCycleException()
         $this->expectException(\UnexpectedValueException::class);
         $this->expectExceptionMessage('Your dependencies have cycles. That will not work out. Cycles found: legacy-hook->package4.listener, package4.listener->legacy-hook');
 
-        $container = $this->getContainerWithListenerProvider([
+        $this->getContainerWithListenerProvider([
             __DIR__ . '/Fixtures/Package1',
             __DIR__ . '/Fixtures/Package4Cycle',
         ]);

diff --git a/typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderCompilationPassTest.php b/typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderCompilationPassTest.php
@@ -188,7 +188,7 @@ public function testExceptionForNonNullableExtensionArgument()
         $this->expectException(\Exception::class);
         $this->expectExceptionMessage('A registered extension for the service "serviceA" requires the service to be available, which is missing.');
 
-        $container = $this->getContainer([
+        $this->getContainer([
             TestServiceProviderOverride::class,
         ]);
     }

diff --git a/typo3/sysext/core/Tests/Unit/Mail/FileSpoolTest.php b/typo3/sysext/core/Tests/Unit/Mail/FileSpoolTest.php
@@ -57,7 +57,7 @@ protected function setUp(): void
     public function spoolsMessagesCorrectly(int $count)
     {
         for ($i = 1; $i <= $count; $i++) {
-            $sentMessage = $this->subject->send(
+            $this->subject->send(
                 new RawMessage('test message ' . $i),
                 new Envelope(new Address('sender@example.com'), [new Address('recipient@example.com')])
             );

diff --git a/typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php b/typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php
@@ -769,7 +769,6 @@ protected function getErrorFlashMessage()
      */
     protected function forwardToReferringRequest(): ?ResponseInterface
     {
-        $referringRequest = null;
         $referringRequestArguments = $this->request->getInternalArguments()['__referrer'] ?? null;
         if (is_string($referringRequestArguments['@request'] ?? null)) {
             $referrerArray = json_decode(

diff --git a/typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php b/typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php
@@ -192,7 +192,6 @@ public function contains($object)
     public function count()
     {
         $columnMap = $this->dataMapper->getDataMap(get_class($this->parentObject))->getColumnMap($this->propertyName);
-        $numberOfElements = null;
         if (!$this->isInitialized && $columnMap->getTypeOfRelation() === ColumnMap::RELATION_HAS_MANY) {
             $numberOfElements = $this->dataMapper->countRelated($this->parentObject, $this->propertyName, $this->fieldValue);
         } else {

diff --git a/typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php b/typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php
@@ -406,7 +406,6 @@ protected function parseDynamicOperand(ComparisonInterface $comparison, SourceIn
     {
         $value = $comparison->getOperand2();
         $fieldName = $this->parseOperand($comparison->getOperand1(), $source);
-        $expr = null;
         $exprBuilder = $this->queryBuilder->expr();
         switch ($comparison->getOperator()) {
             case QueryInterface::OPERATOR_IN:

diff --git a/typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php b/typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php
@@ -54,7 +54,6 @@ public static function configurePlugin($extensionName, $pluginName, array $contr
         self::checkExtensionNameFormat($extensionName);
 
         // Check if vendor name is prepended to extensionName in the format {vendorName}.{extensionName}
-        $vendorName = null;
         $delimiterPosition = strrpos($extensionName, '.');
         if ($delimiterPosition !== false) {
             $vendorName = str_replace('.', '\\', substr($extensionName, 0, $delimiterPosition));
@@ -190,7 +189,6 @@ public static function registerModule($extensionName, $mainModuleName = '', $sub
         self::checkExtensionNameFormat($extensionName);
 
         // Check if vendor name is prepended to extensionName in the format {vendorName}.{extensionName}
-        $vendorName = '';
         if (false !== $delimiterPosition = strrpos($extensionName, '.')) {
             trigger_error(
                 'Calling method ' . __METHOD__ . ' with argument $extensionName containing the vendor name is deprecated and will stop working in TYPO3 11.0.',

diff --git a/typo3/sysext/extbase/Tests/Unit/Persistence/Generic/BackendTest.php b/typo3/sysext/extbase/Tests/Unit/Persistence/Generic/BackendTest.php
@@ -129,7 +129,6 @@ public function getIdentifierByObjectReturnsIdentifierForLazyObject()
     {
         $fakeUuid = 'fakeUuid';
         $configurationManager = $this->createMock(ConfigurationManagerInterface::class);
-        $parentObject = new \stdClass();
         $proxy = $this->getMockBuilder(LazyLoadingProxy::class)
             ->setMethods(['_loadRealInstance'])
             ->disableOriginalConstructor()

diff --git a/typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php b/typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php
@@ -318,7 +318,7 @@ public function mapObjectToClassPropertyReturnsExistingObjectWithoutCallingFetch
         $psrContainer->expects(self::any())->method('has')->willReturn(false);
         $container = new Container($psrContainer);
 
-        $session = new Session(new Container($psrContainer));
+        $session = new Session($container);
         $session->registerObject($child, $identifier);
 
         $mockReflectionService = $this->getMockBuilder(ReflectionService::class)

diff --git a/typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php b/typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php
@@ -206,7 +206,7 @@ public function installDistributionAction(Extension $extension)
         if (!ExtensionManagementUtility::isLoaded('impexp')) {
             return (new ForwardResponse('distributions'))->withControllerName('List');
         }
-        [$result, $errorMessages] = $this->installFromTer($extension);
+        $errorMessages = $this->installFromTer($extension)[1];
         if ($errorMessages) {
             foreach ($errorMessages as $extensionKey => $messages) {
                 foreach ($messages as $message) {

diff --git a/typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php b/typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php
@@ -272,7 +272,7 @@ public function writeExtensionFilesWritesFiles()
                 'content' => 'FEEL FREE TO ADD SOME DOCUMENTATION HERE'
             ]
         ];
-        $rootPath = ($extDirPath = $this->fakedExtensions[$this->createFakeExtension()]['packagePath']);
+        $rootPath = $this->fakedExtensions[$this->createFakeExtension()]['packagePath'];
         $fileHandlerMock = $this->getAccessibleMock(FileHandlingUtility::class, ['makeAndClearExtensionDir']);
         $fileHandlerMock->_call('writeExtensionFiles', $files, $rootPath);
         self::assertTrue(file_exists($rootPath . 'ChangeLog'));

diff --git a/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php b/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
@@ -3793,7 +3793,6 @@ public function http_makelinks($data, $conf)
     {
         $parts = [];
         $aTagParams = $this->getATagParams($conf);
-        $textstr = '';
         foreach (['http://', 'https://'] as $scheme) {
             $textpieces = explode($scheme, $data);
             $pieces = count($textpieces);

diff --git a/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php b/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
@@ -2069,7 +2069,7 @@ public function calculateLinkVars(array $queryParams)
             return;
         }
         foreach ($linkVars as $linkVar) {
-            $test = $value = '';
+            $test = '';
             if (preg_match('/^(.*)\\((.+)\\)$/', $linkVar, $match)) {
                 $linkVar = trim($match[1]);
                 $test = trim($match[2]);

diff --git a/typo3/sysext/frontend/Tests/Unit/Middleware/PageResolverTest.php b/typo3/sysext/frontend/Tests/Unit/Middleware/PageResolverTest.php
@@ -94,7 +94,6 @@ public function handle(ServerRequestInterface $request): ResponseInterface
     public function properSiteConfigurationLoadsPageRouter()
     {
         $incomingUrl = 'https://king.com/lotus-flower/en/mr-magpie/bloom';
-        $pageRecord = ['uid' => 13, 'l10n_parent' => 0, 'slug' => '/mr-magpie/bloom'];
         /** @var MockObject|Site $site */
         $site = $this->getMockBuilder(Site::class)->setConstructorArgs([
             'lotus-flower', 13, [
@@ -136,7 +135,6 @@ public function properSiteConfigurationLoadsPageRouter()
     public function properSiteConfigurationLoadsPageRouterWithRedirect()
     {
         $incomingUrl = 'https://king.com/lotus-flower/en/mr-magpie/bloom/';
-        $pageRecord = ['uid' => 13, 'l10n_parent' => 0, 'slug' => '/mr-magpie/bloom'];
         /** @var MockObject|Site $site */
         $site = $this->getMockBuilder(Site::class)->setConstructorArgs([
             'lotus-flower', 13, [
@@ -176,7 +174,6 @@ public function properSiteConfigurationLoadsPageRouterWithRedirect()
     public function properSiteConfigurationLoadsPageRouterWithRedirectWithoutTrailingSlash()
     {
         $incomingUrl = 'https://king.com/lotus-flower/en/mr-magpie/bloom';
-        $pageRecord = ['uid' => 13, 'l10n_parent' => 0, 'slug' => '/mr-magpie/bloom/'];
         /** @var MockObject|Site $site */
         $site = $this->getMockBuilder(Site::class)->setConstructorArgs([
             'lotus-flower', 13, [

diff --git a/typo3/sysext/indexed_search/Classes/FileContentParser.php b/typo3/sysext/indexed_search/Classes/FileContentParser.php
@@ -461,7 +461,6 @@ protected function sL($reference)
      */
     public function readFileContent($ext, $absFile, $cPKey)
     {
-        $cmd = null;
         $contentArr = null;
         // Return immediately if initialization didn't set support up:
         if (!$this->supportedExtensions[$ext]) {

diff --git a/typo3/sysext/indexed_search/Classes/Indexer.php b/typo3/sysext/indexed_search/Classes/Indexer.php
@@ -700,7 +700,6 @@ public function getUrlHeaders($url)
      */
     protected function createLocalPath($sourcePath)
     {
-        $localPath = '';
         $pathFunctions = [
             'createLocalPathUsingAbsRefPrefix',
             'createLocalPathUsingDomainURL',

diff --git a/typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php b/typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php
@@ -521,7 +521,7 @@ public function fixSelfCallsFixPermissionIfFileExistsButPermissionAreWrong()
         $node->expects(self::any())->method('exists')->willReturn(true);
         $node->expects(self::once())->method('isFile')->willReturn(false);
         $node->expects(self::any())->method('isPermissionCorrect')->willReturn(true);
-        $resultArray = $node->_call('fixSelf');
+        $node->_call('fixSelf');
     }
 
     /**

diff --git a/typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php b/typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php
@@ -757,7 +757,6 @@ public function migrateSaltedPasswordsSettingsDoesNothingIfExtensionConfigsAreEm
     public function migrateSaltedPasswordsSettingsRemovesExtensionsConfigAndSetsNothingElseIfArgon2iIsAvailable()
     {
         $configurationManagerProphecy = $this->prophesize(ConfigurationManager::class);
-        $configurationManagerException = new MissingArrayPathException('Path does not exist in array', 1533989428);
         $configurationManagerProphecy->getLocalConfigurationValueByPath('EXTENSIONS/saltedpasswords')
             ->shouldBeCalled()->willReturn(['thereIs' => 'something']);
         $argonBeProphecy = $this->prophesize(Argon2iPasswordHash::class);

diff --git a/typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php b/typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php
@@ -1279,7 +1279,7 @@ protected function makeValueList($fieldName, $fieldValue, $conf, $table, $splitS
                                     $webMountPageTreePrefix = ',';
                                 }
                                 $webMountPageTree .= $webMountPageTreePrefix
-                                    . $this->getTreeList($webMount, 999, $begin = 0, $perms_clause);
+                                    . $this->getTreeList($webMount, 999, 0, $perms_clause);
                             }
                             if ($from_table === 'pages') {
                                 $queryBuilder->where(
@@ -2710,7 +2710,7 @@ protected function getSelectQuery($qString = ''): string
                     $webMountPageTreePrefix = ',';
                 }
                 $webMountPageTree .= $webMountPageTreePrefix
-                    . $this->getTreeList($webMount, 999, $begin = 0, $perms_clause);
+                    . $this->getTreeList($webMount, 999, 0, $perms_clause);
             }
             // createNamedParameter() is not used here because the SQL fragment will only include
             // the :dcValueX placeholder when the query is returned as a string. The value for the

diff --git a/typo3/sysext/recordlist/Classes/Browser/FileBrowser.php b/typo3/sysext/recordlist/Classes/Browser/FileBrowser.php
@@ -116,7 +116,6 @@ public function processSessionData($data)
      */
     public function render()
     {
-        $_MCONF = [];
         $backendUser = $this->getBackendUser();
 
         // The key number 3 of the bparams contains the "allowed" string. Disallowed is not passed to

diff --git a/typo3/sysext/redirects/Classes/Service/RedirectService.php b/typo3/sysext/redirects/Classes/Service/RedirectService.php
@@ -324,7 +324,7 @@ protected function bootFrontendController(SiteInterface $site, array $queryParam
             $site,
             $site->getDefaultLanguage(),
             new PageArguments($site->getRootPageId(), '0', []),
-            $frontendUserAuthentication = $originalRequest->getAttribute('frontend.user')
+            $originalRequest->getAttribute('frontend.user')
         );
         $controller->determineId($originalRequest);
         $controller->calculateLinkVars($queryParams);