Skip to content

Commit

Permalink
[BUGFIX] Correctly render information boxes if image rendering tests …
Browse files Browse the repository at this point in the history
…fail

Due to a naming mismatch in the refactoring during #87724 it was tried to
render information boxes based on the parent container element.

The code is adjusted now to reference the correct object in the
rendering loop.

Resolves: #91831
Related: #87724
Releases: master, 10.4
Change-Id: Ib80f0f04a9e7ce164be1cd6717fd105d3339b269
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65024
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
  • Loading branch information
andreaskienast committed Jul 21, 2020
1 parent 6e3f539 commit 68cba1d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ class ImageProcessing extends AbstractInteractableModule {

const $twinImageTemplate = this.findInModal(this.selectorTwinImageTemplate);
const promises: Array<Promise<any>> = [];
modalContent.find(this.selectorTestContainer).each((index: number, element: any): void => {
const $container: JQuery = $(element);
modalContent.find(this.selectorTestContainer).each((index: number, container: any): void => {
const $container: JQuery = $(container);
const testType: string = $container.data('test');
const message: any = InfoBox.render(Severity.loading, 'Loading...', '');
$container.empty().html(message);
Expand All @@ -85,7 +85,7 @@ class ImageProcessing extends AbstractInteractableModule {
if (data.success === true) {
$container.empty();
if (Array.isArray(data.status)) {
data.status.forEach((): void => {
data.status.forEach((element: any): void => {
const aMessage = InfoBox.render(element.severity, element.title, element.message);
$container.append(aMessage);
});
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 68cba1d

Please sign in to comment.