Skip to content

Commit

Permalink
[TASK] Remove obsolete setAccessible call to ReflectionMethod
Browse files Browse the repository at this point in the history
Also adjust variable name along the way.

Resolves: #103679
Related: #103667
Releases: main
Change-Id: I345dabbd388eaac9e5a56af6b70e249c4bac0feb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83932
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
  • Loading branch information
nhovratov committed Apr 19, 2024
1 parent 162a25d commit 7745ba1
Showing 1 changed file with 2 additions and 4 deletions.
Expand Up @@ -129,7 +129,6 @@ public function loadAvailableWizardsFromContentElementsReturnsExpectedArray(arra
NewContentElementController::class,
'loadAvailableWizardsFromContentElements'
);
$loadAvailableWizardsFromContentElements->setAccessible(true);

$GLOBALS['TCA']['tt_content']['columns']['list_type']['config']['items'] = [];
ExtensionManagementUtility::addTcaSelectItem(
Expand Down Expand Up @@ -173,11 +172,10 @@ public function loadAvailableWizardsFromPluginSubTypeReturnsExpectedArray(array
$group = $item['group'] ?? '';
$type = $item['value'];
$newContentElementWizardController = $this->get(NewContentElementController::class);
$loadAvailableWizardsFromContentElements = new \ReflectionMethod(
$loadAvailableWizardsFromPluginSubTypes = new \ReflectionMethod(
NewContentElementController::class,
'loadAvailableWizardsFromPluginSubTypes'
);
$loadAvailableWizardsFromContentElements->setAccessible(true);

// items array is undefined in TCA, add empty array.
$GLOBALS['TCA']['tt_content']['columns']['list_type']['config']['items'] = [];
Expand All @@ -187,7 +185,7 @@ public function loadAvailableWizardsFromPluginSubTypeReturnsExpectedArray(array
$item
);

$result = $loadAvailableWizardsFromContentElements->invoke($newContentElementWizardController);
$result = $loadAvailableWizardsFromPluginSubTypes->invoke($newContentElementWizardController);
$actual = $result[$group . '.']['elements.'][$type . '.'] ?? [];
self::assertSame($expected, $actual);
}
Expand Down

0 comments on commit 7745ba1

Please sign in to comment.