Skip to content

Commit

Permalink
[!!!][TASK] Make language module part of install extension
Browse files Browse the repository at this point in the history
The language module changes configuration files and basic
instance system files and thus belongs to the install extension.

The patch moves the "Admin Tools" -> "Language" module to
"Maintenance" -> "Manage language packs" and comes with a
series of advantages:
* UX improvements and better overview
* Overall language pack update progress is much quicker
* Just a fraction of code needed
* No dependency to extension manager anymore
* Documentation extension has no hidden dependency to lang anymore

Change-Id: Ibcb9659dfacb5fda7c00ab2f39160f095e0cd154
Resolves: #84131
Releases: master
Reviewed-on: https://review.typo3.org/55998
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
  • Loading branch information
lolli42 committed Mar 5, 2018
1 parent db6bfaf commit 780c302
Show file tree
Hide file tree
Showing 49 changed files with 1,263 additions and 3,776 deletions.
1 change: 0 additions & 1 deletion Build/Resources/Public/Sass/backend.scss
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
@import "typo3/debugconsole";
@import "typo3/module_web_list_sysnote";
@import "typo3/module_extensionmanager";
@import "typo3/module_lang";
@import "typo3/module_beuser";
@import "typo3/module_cshmanual";
@import "typo3/wizard_localization";
Expand Down
6 changes: 6 additions & 0 deletions Build/Resources/Public/Sass/install.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,15 @@ $grid-float-breakpoint: $screen-md-min;
@import "component/card";
@import "component/colorpicker";
@import "typo3/main_form";
@import "typo3/icons";

//
// Include elements
//

@import "typo3/element_docheader";
@import "typo3/element_message";
@import "typo3/element_table";

body.backend .module {
background: $gray-lighter;
Expand Down Expand Up @@ -75,6 +77,10 @@ img.logo {
}
}

.t3-languagePacks-inactive {
color: #aaa;
}

.bg-transparent-emulation {
padding: 10px;
text-align: center;
Expand Down
161 changes: 0 additions & 161 deletions Build/Resources/Public/Sass/typo3/_module_lang.scss

This file was deleted.

2 changes: 0 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@
"TYPO3\\CMS\\IndexedSearch\\": "typo3/sysext/indexed_search/Classes/",
"TYPO3\\CMS\\Info\\": "typo3/sysext/info/Classes/",
"TYPO3\\CMS\\Install\\": "typo3/sysext/install/Classes/",
"TYPO3\\CMS\\Lang\\": "typo3/sysext/lang/Classes/",
"TYPO3\\CMS\\Linkvalidator\\": "typo3/sysext/linkvalidator/Classes/",
"TYPO3\\CMS\\Lowlevel\\": "typo3/sysext/lowlevel/Classes/",
"TYPO3\\CMS\\Opendocs\\": "typo3/sysext/opendocs/Classes/",
Expand Down Expand Up @@ -207,7 +206,6 @@
"TYPO3\\CMS\\Impexp\\Tests\\": "typo3/sysext/impexp/Tests/",
"TYPO3\\CMS\\IndexedSearch\\Tests\\": "typo3/sysext/indexed_search/Tests/",
"TYPO3\\CMS\\Install\\Tests\\": "typo3/sysext/install/Tests/",
"TYPO3\\CMS\\Lang\\Tests\\": "typo3/sysext/lang/Tests/",
"TYPO3\\CMS\\Lowlevel\\Tests\\": "typo3/sysext/lowlevel/Tests/",
"TYPO3\\CMS\\Recordlist\\Tests\\": "typo3/sysext/recordlist/Tests/",
"TYPO3\\CMS\\Reports\\Tests\\": "typo3/sysext/reports/Tests/",
Expand Down
2 changes: 1 addition & 1 deletion typo3/sysext/backend/Resources/Public/Css/backend.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions typo3/sysext/core/Classes/Localization/Locales.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class Locales implements \TYPO3\CMS\Core\SingletonInterface
'bs' => 'Bosnian',
'bg' => 'Bulgarian',
'ca' => 'Catalan',
'ch' => 'Chinese (Simpl.)',
'ch' => 'Chinese (Simple)',
'cs' => 'Czech',
'da' => 'Danish',
'de' => 'German',
Expand Down Expand Up @@ -84,7 +84,7 @@ class Locales implements \TYPO3\CMS\Core\SingletonInterface
'tr' => 'Turkish',
'uk' => 'Ukrainian',
'vi' => 'Vietnamese',
'zh' => 'Chinese (Trad.)'
'zh' => 'Chinese (Trad)'
];

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
.. include:: ../../Includes.txt

========================================================
Breaking: #84131 - Removed classes of language extension
========================================================

See :issue:`84131`

Description
===========

The language pack update module - formerly known as "Admin Tools" -> "Language"
module has been moved to "Maintenance" -> "Manage language packs".

PHP classes implementing the old solution have been removed:
* :php:`TYPO3\CMS\Lang\Command\LanguageUpdateCommand`
* :php:`TYPO3\CMS\Lang\Controller\LanguageController`
* :php:`TYPO3\CMS\Lang\Domain\Model\Extension`
* :php:`TYPO3\CMS\Lang\Domain\Model\Language`
* :php:`TYPO3\CMS\Lang\Domain\Repository\ExtensionRepository`
* :php:`TYPO3\CMS\Lang\Domain\Repository\LanguageRepository`
* :php:`TYPO3\CMS\Lang\Exception`
* :php:`TYPO3\CMS\Lang\Exception\Language`
* :php:`TYPO3\CMS\Lang\Exception\Ter`
* :php:`TYPO3\CMS\Lang\Exception\XmlParser`
* :php:`TYPO3\CMS\Lang\Service\RegistryService`
* :php:`TYPO3\CMS\Lang\Service\TerService`
* :php:`TYPO3\CMS\Lang\Service\TranslationService`
* :php:`TYPO3\CMS\Lang\View\AbstractJsonView`
* :php:`TYPO3\CMS\Lang\View\Language\ActivateLanguageJson`
* :php:`TYPO3\CMS\Lang\View\Language\DeactivateLanguageJson`
* :php:`TYPO3\CMS\Lang\View\Language\GetTranslationsJson`
* :php:`TYPO3\CMS\Lang\View\Language\RemoveLanguageJson`
* :php:`TYPO3\CMS\Lang\View\Language\UpdateLanguageJson`
* :php:`TYPO3\CMS\Lang\View\Language\UpdateTranslationJson`


Impact
======

Using one of the mentioned classes will throw a fatal PHP error.


Affected Installations
======================

It is unlikely extensions used the mentioned classes, the extension scanner will find usages.


Migration
=========

No migration available.

.. index:: Backend, PHP-API, FullyScanned, ext:lang

0 comments on commit 780c302

Please sign in to comment.