Skip to content

Commit

Permalink
[TASK] Update phpstan/phpstan:^1.10.51
Browse files Browse the repository at this point in the history
New phpstan find some questionable null fallback occurences, that are
not obvious. Add a baseline for now.

> composer req --dev phpstan/phpstan:^1.10.51
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Resolves: #102756
Releases: main, 12.4
Change-Id: I3eef057d4fd04fe92f813bad7e1873718f6da765
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82357
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Stefan Bürk <stefan@buerk.tech>
  • Loading branch information
maddy2101 authored and sbuerk committed Jan 6, 2024
1 parent d250d1f commit e64fbb7
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 7 deletions.
15 changes: 15 additions & 0 deletions Build/phpstan/phpstan-baseline.neon
Expand Up @@ -60,6 +60,11 @@ parameters:
count: 1
path: ../../typo3/sysext/backend/Classes/Form/Behavior/UpdateValueOnFieldChange.php

-
message: "#^Offset 'onChange' on array\\{label\\: string, config\\: mixed, children\\: mixed, onChange\\: mixed, description\\?\\: mixed\\} in isset\\(\\) always exists and is not nullable\\.$#"
count: 1
path: ../../typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php

-
message: "#^Offset 'isInlineDefaultLang…' on array on left side of \\?\\? always exists and is not nullable\\.$#"
count: 1
Expand Down Expand Up @@ -125,6 +130,11 @@ parameters:
count: 1
path: ../../typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php

-
message: "#^Variable \\$translations on left side of \\?\\? always exists and is not nullable\\.$#"
count: 1
path: ../../typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php

-
message: "#^Method TYPO3\\\\CMS\\\\Backend\\\\Routing\\\\PreviewUriBuilder\\:\\:create\\(\\) should return static\\(TYPO3\\\\CMS\\\\Backend\\\\Routing\\\\PreviewUriBuilder\\) but returns object\\.$#"
count: 1
Expand Down Expand Up @@ -2950,6 +2960,11 @@ parameters:
count: 1
path: ../../typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php

-
message: "#^Variable \\$var on left side of \\?\\? always exists and is not nullable\\.$#"
count: 5
path: ../../typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php

-
message: "#^Negated boolean expression is always false\\.$#"
count: 1
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -112,7 +112,7 @@
"friendsofphp/php-cs-fixer": "^3.46",
"friendsoftypo3/phpstan-typo3": "^0.9.0",
"php-webdriver/webdriver": "^1.14.0",
"phpstan/phpstan": "^1.10.48",
"phpstan/phpstan": "^1.10.51",
"phpstan/phpstan-phpunit": "^1.3.15",
"phpunit/phpunit": "^10.5.5",
"sokil/php-isocodes-db-i18n": "^4.0.18",
Expand Down
12 changes: 6 additions & 6 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e64fbb7

Please sign in to comment.