Skip to content

Commit

Permalink
[TASK] Call getDomainStartPage without third parameter
Browse files Browse the repository at this point in the history
The third parameter in PageRepository->getDomainStartPage
is not used anymore. Saving an extra call to GeneralUtility
to not hand this parameter over to the method in TSFE should be helpful.

However, in the future, this method will probably be changed,
the third parameter is not deprecated for now.

Resolves: #84043
Releases: master
Change-Id: I397dd86d703f4fa5778794209e90ffaa82baf872
Reviewed-on: https://review.typo3.org/55901
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
  • Loading branch information
bmack authored and NeoBlack committed Feb 26, 2018
1 parent 6b18e40 commit f060e85
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1851,15 +1851,15 @@ public function findDomainRecord($recursive = false)
$pageUid = 0;
$host = explode('.', GeneralUtility::getIndpEnv('HTTP_HOST'));
while (count($host)) {
$pageUid = $this->sys_page->getDomainStartPage(implode('.', $host), GeneralUtility::getIndpEnv('SCRIPT_NAME'), GeneralUtility::getIndpEnv('REQUEST_URI'));
$pageUid = $this->sys_page->getDomainStartPage(implode('.', $host), GeneralUtility::getIndpEnv('SCRIPT_NAME'));
if ($pageUid) {
return $pageUid;
}
array_shift($host);
}
return $pageUid;
}
return $this->sys_page->getDomainStartPage(GeneralUtility::getIndpEnv('HTTP_HOST'), GeneralUtility::getIndpEnv('SCRIPT_NAME'), GeneralUtility::getIndpEnv('REQUEST_URI'));
return $this->sys_page->getDomainStartPage(GeneralUtility::getIndpEnv('HTTP_HOST'), GeneralUtility::getIndpEnv('SCRIPT_NAME'));
}

/**
Expand Down

0 comments on commit f060e85

Please sign in to comment.