[BUGFIX] Fix new forms from predefined core form have no validation #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mai-space
added a commit
to mai-space/typo3
that referenced
this pull request
Sep 6, 2023
Tasks: * Added missing fluidAdditionalAttribute required * Fixed yaml file quotation Resolves: #TYPO3#459 Releases: main, 11.5
Tasks: * Added missing fluidAdditionalAttribute required * Fixed yaml file quotation Resolves: #TYPO3#459 Releases: main, 11.5
|
Thanks to @benjamingries for pointing out that I had mistakingly mixed up form types while providing this fix. This is fixed now :) |
|
Please use our Gerrit review system directly. In the meantime this has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed in our project, when creating a new form from the predefined from "SimpleContactForm" that the fields are marked as required, but do not actually have the fluidAdditionalAttribute required until the field was clicked at and saved.
In order to fix this, this Pull Request adds the missing attribute.