Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[TASK] Allow rendering without stack through View (#174)" #202

Merged
merged 1 commit into from
Oct 17, 2016

Conversation

NamelessCoder
Copy link
Member

This reverts commit 81dbc0e.

Close: #201

@NamelessCoder
Copy link
Member Author

@kitsunet if you are still up, you are welcome to merge this one (and I will then tag 1.1.2 right after). Good catch btw, but be careful you don't have a bug in the code you are writing regarding #201 - the fact that you hit this case could indicate that you have some incompletely initialised View being used to render a template, e.g. startRendering was not called and the stack is therefore empty, or the stack was incorrectly popped. Just something to watch out for :)

@kitsunet
Copy link
Member

Yep, still up, works flawlessly. I think I know why we hit that case, maybe something to discuss about individually because it's an important use case for us. We render sections within a template without actually rendering the full template.

Merging, thanks for fast reaction! 👍

@kitsunet kitsunet merged commit d95f2af into TYPO3:1.1 Oct 17, 2016
@NamelessCoder NamelessCoder deleted the badfunction branch October 17, 2016 23:05
@NamelessCoder
Copy link
Member Author

We render sections within a template without actually rendering the full template.

That is the exact use case I had in mind. You may want to check out a72efbd which is the reason the fallbacks were implemented - I knew in advance this would come up, but it should still be exclusive to the 2.0 branch and 1.0 / 1.1 will have to make do :)

There's a related patch I've been wanting to do which moves the whole stack handling away from the View, further separating the concerns. Maybe that will also allow us to somewhat clean up the TemplateParser which has a pretty big set of couplings and dependencies...

@NamelessCoder
Copy link
Member Author

1.1.2 has been tagged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants