Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created a component for tebleau logo #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yashsuhagiya
Copy link

#22 (comment)

  • Fixed the naming of the folders
  • Created a tebleau logo components that returns logo and text
  • In mobile view, only logo is visible, not the text

@stephenlprice
Copy link
Contributor

hey @yashsuhagiya I appreciate your contribution. I realize this issue was not very clear in intention as it was more of a note for myself as I get the repository ready for others to join. For example, I need to mention usage of tailwind and daisyui etc. This should happen soon.

Even though I had a different intention. I like what you did here. I'll soon create an issue to better describe something similar that I have in mind for the Viz component and let you know.

@stephenlprice
Copy link
Contributor

stephenlprice commented Oct 19, 2023

In case you were curious, the way I wanted to integrate the logo was via Nextra's theme.config.tsx where I import and use the logo component: https://github.com/Tab-SE/embedding_playbook/blob/kickoff/theme.config.tsx

It has to use the Img component so that it routes correctly to the IMGIX host in production.

After testing it did not seem necessary to remove the title on mobile layouts since the hamburger menu displays the navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants