Fix cursor navigation / handle motion modifiers #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the current cell is always fully visible when moving the cursor (fixes TabViewer#89). Handle motion modifiers along the way (fixes TabViewer#93).
|
Really good work here! I think that cleaned up and clarified a lot. I'd spent time on both these issues...wasn't anywhere near this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the current cell is always fully visible when moving the cursor (fixes #89).
Handle motion modifiers along the way (fixes #93).
Some previous fixes to ensure the cursor is always visible were basically killed in the PR for variable column lengths. Actually, most motion commands were broken when moving around left/right in files with variable columns lengths.