Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw strength counts opponents without confirmed results #1466

Closed
czlee opened this issue May 25, 2020 · 0 comments · Fixed by #2364
Closed

Draw strength counts opponents without confirmed results #1466

czlee opened this issue May 25, 2020 · 0 comments · Fixed by #2364

Comments

@czlee
Copy link
Member

czlee commented May 25, 2020

It's not clear to me what the behaviour should be, just something I noticed when writing unit tests.

If there is a debate with only unconfirmed ballots, then this debate doesn't count towards the second-order metrics used in calculating draw strength, but the fact that it is drawn does count for the purposes of determining who a team's opponents have been when calculating draw strength. This is arguably a strange inconsistency—we are counting their opponents' record in a team's draw strength, even when it isn't fully accounted for that they faced the opponent.

For now, I've marked these as expected failures in 78ca17f.

czlee added a commit that referenced this issue May 25, 2020
- Moved elimination round tests to separate tests #1073
- Added checks for unconfirmed ballots
- Suppress routine logs to prevent clutter when run from command line
- Two expected failures in draw strength, see #1466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant