Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ballots' column in private URL table is not in the same order #2369

Closed
tienne-B opened this issue Dec 9, 2023 · 0 comments · Fixed by #2371
Closed

Ballots' column in private URL table is not in the same order #2369

tienne-B opened this issue Dec 9, 2023 · 0 comments · Fixed by #2371

Comments

@tienne-B
Copy link
Member

tienne-B commented Dec 9, 2023

No description provided.

tienne-B added a commit that referenced this issue Dec 9, 2023
@tienne-B
Keep order of debates in private URL ballot column
5611832 
This commit keeps the order of debates for ballot links as given,
despite the debate query being replaced by another one. The objects from
the new query get put into a dict to be accessed in the iteration of
debates, in order to keep them sorted.

The alternative was to sort the query by round sequence, but that would
be less generalizable.

Fixes #2369
@tienne-B tienne-B mentioned this issue Dec 9, 2023
Merged
tienne-B added a commit that referenced this issue Jan 26, 2024
@tienne-B
Keep order of debates in private URL ballot column
5886f4e 
This commit keeps the order of debates for ballot links as given,
despite the debate query being replaced by another one. The objects from
the new query get put into a dict to be accessed in the iteration of
debates, in order to keep them sorted.

The alternative was to sort the query by round sequence, but that would
be less generalizable.

Fixes #2369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep order of debates in private URL ballot column TabbycatDebate/tabbycat
1 participant
@tienne-B