Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altering perspective doesn't change annotations for an object #242

Closed
nissim-panchpor opened this issue Dec 26, 2018 · 2 comments
Closed
Labels
bug Anything that is supposed to work, but doesn't.
Milestone

Comments

@nissim-panchpor
Copy link

Hi Daniel,
Recently noticed that removing an object from a perspective doesn't remove the "TabularEditor_InPerspective" annotation and corresponding value. For eg. I wanted to remove a column from a perspective. The column had an annotation with the above name and perspective name as its value. When I tried to remove the column from perspective, it was removed from the list but this annotation remained as it is. When I saved and reopened the model, the column was still in that perspective.
Please let me know if you have any questions. Thanks!

  • Nissim Panchpor
@nissim-panchpor nissim-panchpor changed the title Perspective doesn't change annotations Altering perspective doesn't change annotations for an object Dec 26, 2018
@otykier
Copy link
Collaborator

otykier commented Jan 4, 2019

Hi Nissim,
Thanks for reporting this. It will be fixed in the upcoming 2.8 release.

Annotations containing redundant metadata such as "TabularEditor_InPerspective" were never intended to be visible in the UI. Going forward, all such annotations will be removed from the model after it has been loaded into the UI, as the annotations are only needed when serializing the model into a folder structure.

This should fix the issue you're seeing.

@otykier otykier added the bug Anything that is supposed to work, but doesn't. label Jan 4, 2019
otykier added a commit that referenced this issue Jan 4, 2019
@otykier otykier added this to the 2.8 milestone Jan 9, 2019
@otykier
Copy link
Collaborator

otykier commented Jan 23, 2019

Fixed in 2.8

@otykier otykier closed this as completed Jan 23, 2019
SergioMurru pushed a commit to SergioMurru/TabularEditor that referenced this issue Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Anything that is supposed to work, but doesn't.
Projects
None yet
Development

No branches or pull requests

2 participants