Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best Practice Analyser issue counts includes ignored #368

Closed
o-o00o-o opened this issue Dec 4, 2019 · 1 comment
Closed

Best Practice Analyser issue counts includes ignored #368

o-o00o-o opened this issue Dec 4, 2019 · 1 comment
Labels
bug Anything that is supposed to work, but doesn't.
Milestone
2.9.0

Comments

@o-o00o-o
Copy link

o-o00o-o commented Dec 4, 2019

We have a few BP rules that we have to ignore for now but we still get the indicator in the status bar saying we have issues. This removes the benefit of this as unless we track what the number was at the beginning we can't quickly see if we have introduced any new issues that need addressing

image

Pehaps it would be better to say "X issues and Y ignored" . X Issues could be in Red, Y ignored could be in blue.

Also confusing on the BP Analyser screen as you can see it says 16 objects in violation but can only see 5 of them as the rest are ignored.
image
@o-o00o-o o-o00o-o changed the title Best Practice Analyser "X objects in violation" and "X BP Issues" should not include ignored BP rules Best Practice Analyser issue counts includes ignored Dec 4, 2019
@otykier otykier added the bug Anything that is supposed to work, but doesn't. label Dec 6, 2019
@otykier
Copy link
Collaborator

otykier commented Dec 6, 2019

Clearly a bug. Thanks for reporting. Will be fixed shortly.

@otykier otykier added this to the 2.8.7 milestone Dec 6, 2019
otykier pushed a commit that referenced this issue Dec 7, 2019
Fix issue #368
5d88f5e
@otykier otykier closed this as completed in 4171e94 Dec 7, 2019
SergioMurru pushed a commit to SergioMurru/TabularEditor that referenced this issue Feb 13, 2023
Fix issue TabularEditor#368
fe2a358
SergioMurru pushed a commit to SergioMurru/TabularEditor that referenced this issue Feb 13, 2023
Fix TabularEditor#368
c863e1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Anything that is supposed to work, but doesn't.
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
2 participants
@otykier @o-o00o-o