no indication of broken Best Practice rules until deploy

[o-o00o-o]

We had an unexpected experience last week with BP rules. I had changed a rule to have bad syntax and used IS NOT NULL instead of != null (doing too much SQL recently :)). However there were no errors given in the UI and actually the BP rule stopped returning the failing ones (so I assumed that it had solved the issue)

However on committing and deploying we found that the build was erroring. In fact it wasn't erroring it was warning so everything still seemed to work, with the issue now that we thought we had a BP rule in effect but it wasn't

So I think there are a couple of issues here that should be addressed

1. BP rule "Blah" with constraint "GetAnnotation("blah") is not null" doesn't indicate any error in the UI
2. When deploying even with -ERR, the BP errors are shown only as Warnings (warnings are my original errors not the Blah case as above, but you get the idea)

start /b /wait D:\a\1\s\build\TabularEditor\TabularEditor.exe D:\a\1\s\src\VegaDW.Cube\database.json -ANALYZE -VSTS -ERR

    Tabular Editor 2.9.1 (build 2.9.7282.17172)
     --------------------------------
     Loading custom actions from: C:\Users\bgerhardi\AppData\Local\TabularEditor\CustomActions.json
     Dependency tree built in 1555 ms
     Loading model...
     Running Best Practice Analyzer...
     =================================
     ##vso[task.logissue type=warning;]Error on rule 'Prevent Hidden or Numeric columns to Be Available in MDX': Operator 'AND' incompatible with operand types 'Boolean' and 'String'
     ##vso[task.logissue type=warning;]Error on rule 'Sorted Columns Should Not Be Hidden': Operator 'AND' incompatible with operand types 'Boolean' and 'String'
     ##vso[task.logissue type=warning;]Error on rule 'Columns Used to Sort Others Should Be Hidden': Operator 'AND' incompatible with operand types 'Boolean' and 'String'
     =================================

[otykier]

The UI actually displays an error when the expression editor loses focus:

Unfortunately, if you hit the "OK" button you might not have noticed the error message, as the dialog closes immediately. Would it be better to display a confirmation box in case an expression has an error when the "OK" button is clicked?

Also - do you think the BPA UI (below) should display rules that have an error in their expression?

Regarding #2, I can certainly change the type to be "error" instead of "warning". I don't recall the rationale behind only showing them as warnings previously.

[o-o00o-o]

Yeah i think it would be most obvious if it showed in the BP errors (and included in the count of BP errors in the status bar). A warning dialog on exit would also be good, but easily missed so the persistent error covers that angle. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Daniel Otykier <notifications@github.com> Sent: Monday, January 20, 2020 2:23:13 PM To: otykier/TabularEditor <TabularEditor@noreply.github.com> Cc: o-o00o-o <brett@zerozero.net>; Author <author@noreply.github.com> Subject: Re: [otykier/TabularEditor] no indication of broken Best Practice rules until deploy (#384) The UI actually displays an error when the expression editor loses focus: [image]<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F8976200%2F72733241-bfab5a80-3b97-11ea-9728-0cc236bc9f64.png&data=02%7C01%7C%7C12f7d7f862584fa92c4a08d79db448a5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637151269942444895&sdata=XmIFvqzUFGNEdOHaRyMrbW%2BLkUNBmV0%2FneVLpEdetR8%3D&reserved=0> Unfortunately, if you hit the "OK" button you might not have noticed the error message, as the dialog closes immediately. Would it be better to display a confirmation box in case an expression has an error when the "OK" button is clicked? Also - do you think the BPA UI (below) should display rules that have an error in their expression? [image]<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F8976200%2F72733720-b242a000-3b98-11ea-99c9-c8562168bb2b.png&data=02%7C01%7C%7C12f7d7f862584fa92c4a08d79db448a5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637151269942454906&sdata=cf%2Fjt0yLrTpfeTVWelbSNJcvpiHChtSlwPwcsfTfBRQ%3D&reserved=0> Regarding #2<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fotykier%2FTabularEditor%2Fissues%2F2&data=02%7C01%7C%7C12f7d7f862584fa92c4a08d79db448a5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637151269942464917&sdata=t%2FM7WiocEc%2F%2FQEs3zCl5Iha3aLq9DfY5j%2FJ54HreNh0%3D&reserved=0>, I can certainly change the type to be "error" instead of "warning". I don't recall the rationale behind only showing them as warnings previously. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fotykier%2FTabularEditor%2Fissues%2F384%3Femail_source%3Dnotifications%26email_token%3DADIPBZYZVYMMQRDKVBNMJKDQ6WXVDA5CNFSM4KJCBOAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJMZMHQ%23issuecomment-576296478&data=02%7C01%7C%7C12f7d7f862584fa92c4a08d79db448a5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637151269942474928&sdata=Qmg9TvzkdU1rKS8yYSa3sxFgfVhzijqXDA3HR%2FVup1Y%3D&reserved=0>, or unsubscribe<https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADIPBZ6EW7JPLTWDQXSOYFDQ6WXVDANCNFSM4KJCBOAA&data=02%7C01%7C%7C12f7d7f862584fa92c4a08d79db448a5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637151269942484933&sdata=Rh8KxTQOb%2FJvQ4KUYqdG8u9do%2Bqie2ABjVyNHoQoh3Q%3D&reserved=0>.

[otykier]

Fixed in 2.9.3