Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8.8] ProtocolSupport incompatibility #49

Closed
Bonista opened this issue Sep 25, 2016 · 9 comments
Closed

[1.8.8] ProtocolSupport incompatibility #49

Bonista opened this issue Sep 25, 2016 · 9 comments

Comments

@Bonista
Copy link

Bonista commented Sep 25, 2016

http://pastebin.com/Tk7xZpLf

Is this something I have to fix with ProtocolSupport or is it TacoSpigot's issue?

If it is something I have to fix, I would appreciate your help in directing me to the right route.

@Bonista
Copy link
Author

Bonista commented Sep 25, 2016

I found out where the problem lies.

PaperMC/Paper@4c7641d

Time to clone the repo and fix it ;-;

@Bonista
Copy link
Author

Bonista commented Sep 25, 2016

I changed Short.MAX_VALUE to Short.MAX_VALUE * 10, which is a terrible fix for it.

What would other people do? What is the max length of a packet for 1.7?

@Techcable
Copy link
Contributor

I'm not sure you can legitimately receive a packet longer than Short.MAX_BYTES, so it could be that somebody's trying to attack you. Is it you having this issue, or one of your players?

@Bonista
Copy link
Author

Bonista commented Sep 26, 2016

@Techable unfortunately its all 1.7 players

@Bonista
Copy link
Author

Bonista commented Sep 26, 2016

@CheatSupport
Copy link

Any updates? I would love this.

@SnakeDaoust1232 did you get it to work?

@CheatSupport
Copy link

@SnakeDaoust1232 for taco spigot? Also can you like me protocolsupport you have, it would be very appreciated.

@CheatSupport
Copy link

@SnakeDaoust1232 please link me your protocolsupport.jar file?

@SnakeDaoust1232
Copy link

SnakeDaoust1232 commented May 14, 2017

@Bonista I would like your tacospigot jar that you got working. Are you available?

Im getting same error:

SnakeDaoust lost connection: Internal Exception: io.netty.handler.codec.EncoderException: io.netty.handler.codec.DecoderException: The received a byte array longer than allowed 61696 > 32767

Techcable added a commit that referenced this issue Jun 7, 2017
This only affects people using ProtocolSupport with 1.7,
and shouldn't make anyone else vulnerable.
This commit is untested, and may have bugs.

Fixes #63
Fixes #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants