-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.8.8] ProtocolSupport incompatibility #49
Comments
I found out where the problem lies. Time to clone the repo and fix it ;-; |
I changed Short.MAX_VALUE to Short.MAX_VALUE * 10, which is a terrible fix for it. What would other people do? What is the max length of a packet for 1.7? |
I'm not sure you can legitimately receive a packet longer than Short.MAX_BYTES, so it could be that somebody's trying to attack you. Is it you having this issue, or one of your players? |
@Techable unfortunately its all 1.7 players |
https://github.com/ProtocolSupport/ProtocolSupport/blob/master/src/protocolsupport/protocol/serializer/ProtocolSupportPacketDataSerializer.java (Current version (1.10)) https://github.com/ProtocolSupport/ProtocolSupport/blob/29d9ba0476029bf976487d0653acdf135fd345b4/src/protocolsupport/protocol/PacketDataSerializer.java (The version that works with 1.8.8) I believe this is where it's supposed to be fixed, and TacoSpigot shouldn't be touched. What do you suggest doing? |
Any updates? I would love this. @SnakeDaoust1232 did you get it to work? |
@SnakeDaoust1232 for taco spigot? Also can you like me protocolsupport you have, it would be very appreciated. |
@SnakeDaoust1232 please link me your protocolsupport.jar file? |
@Bonista I would like your tacospigot jar that you got working. Are you available? Im getting same error: SnakeDaoust lost connection: Internal Exception: io.netty.handler.codec.EncoderException: io.netty.handler.codec.DecoderException: The received a byte array longer than allowed 61696 > 32767 |
http://pastebin.com/Tk7xZpLf
Is this something I have to fix with ProtocolSupport or is it TacoSpigot's issue?
If it is something I have to fix, I would appreciate your help in directing me to the right route.
The text was updated successfully, but these errors were encountered: