Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #619

Merged
merged 15 commits into from Nov 29, 2018
Merged

Develop #619

merged 15 commits into from Nov 29, 2018

Conversation

TadasBaltrusaitis
Copy link
Owner

TadasBaltrusaitis and others added 15 commits September 18, 2018 08:24
* Header guard cleanup (making sure naming is compliant with C++ standards and consistent).

* Removing un-needed nullptr checks.

* Removing SSE warnings for x64 builds (as SSE is enabled by default no need for a flag)

* Reverting Mat deletion
- name of revision
- better scripts for model download (not only in Dropbox also OneDrive)
Removing a TBB dependence for code parallelization (done through OpenCV's parralel_for_
Updating the 64 bit OpenBLAS version for Windows to 0.3.3 (50% perf improvement on certain machines)
- Automatically choose correct path to the model files so that it works for both, source code compilation and binary use
- Use absolute paths in the system exists methods
@TadasBaltrusaitis
Copy link
Owner Author

  • Removing TBB dependency. TBB can still be used, but is called through OpenCV (
    TBB can be replaced with cv::parallel_for_ #241)
  • Updating OpenBLAS version in 64-bit Windows builds (should lead to significant performance gains on that architecture)
  • Allow specifying image output format (for both aligned images and visualized images). See wiki for more details
  • Removing unused -q flag (Quiet mode ignored #593)

@TadasBaltrusaitis TadasBaltrusaitis merged commit caaefae into master Nov 29, 2018
ratgen pushed a commit to ratgen/OpenFace that referenced this pull request Jul 7, 2022
* Removing code duplication and getting rid of some C++ warnings due to float/double and signed/unsigned mixing.

* Fixing the screenshot functionality.

* Feature/code cleanup (TadasBaltrusaitis#573)

* Header guard cleanup (making sure naming is compliant with C++ standards and consistent).

* Removing un-needed nullptr checks.

* Removing SSE warnings for x64 builds (as SSE is enabled by default no need for a flag)

* Reverting Mat deletion

* Adding Visual Studio 2017 solution

* Feature/code cleanup (TadasBaltrusaitis#580)

- name of revision
- better scripts for model download (not only in Dropbox also OneDrive)

* Update the OpenCV constants to the corresponding ones in cpp namespace. (TadasBaltrusaitis#578)

Updating OpenCV macros.

* Slight change in packaging code (use a shared download script).

* Removing TBB dependency (TadasBaltrusaitis#590)

Removing a TBB dependence for code parallelization (done through OpenCV's parralel_for_

* Updating OpenBLAS (TadasBaltrusaitis#594)

Updating the 64 bit OpenBLAS version for Windows to 0.3.3 (50% perf improvement on certain machines)

* Ability to specify output image formats and removing unused quiet parameter.

* Update Windows download script (TadasBaltrusaitis#608) (TadasBaltrusaitis#610)

- Automatically choose correct path to the model files so that it works for both, source code compilation and binary use
- Use absolute paths in the system exists methods

* Updating version.

* Packaging code update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants