Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brushup admin interface #2

Merged
merged 10 commits into from Jul 2, 2014
Merged

brushup admin interface #2

merged 10 commits into from Jul 2, 2014

Conversation

ssahara
Copy link
Contributor

@ssahara ssahara commented May 19, 2014

Hi, Taggic. I recently installed the LangDelete plugin and find that it is much helpful to keep reduced files under our daily backup. The current version of the plugin worked fine with the most recent DokuWiki 2014-05-05 "Ponder Stibbons".

I think that there is something I can do to improve the plugin:

  • use DokuWiki's msg() function to display any message, to accommodate better with dokuwiki template
  • rework Input form design, to emphasize that admin must specify Lang-code that he want to keep, not delete
  • separate longer text in lang.php to text file for easing translation to other languages.

It is glad if you like my work for the plugin, even I could not complete german language files.

Taggic added a commit that referenced this pull request Jul 2, 2014
brushup admin interface
@Taggic Taggic merged commit 1e19563 into Taggic:master Jul 2, 2014
@Taggic
Copy link
Owner

Taggic commented Jul 2, 2014

Hi,

thank you very much for your efforts and improvements on this plugin. I will merge it as you proposed.
Please feel free to further improve the code and functionality.

best regards
Taggic

@Taggic
Copy link
Owner

Taggic commented Jul 2, 2014

Hi Satoshi,

I've just merged the code. Thank you very much for your efforts and
valuable improvements to this plugin.

best regards
Taggic

Am 19.05.2014 08:07, schrieb Satoshi Sahara:

Hi, Taggic. I recently installed the LangDelete plugin and find that
it is much helpful to keep reduced files under our daily backup. The
current version of the plugin worked fine with the most recent
DokuWiki 2014-05-05 "Ponder Stibbons".

I think that there is something I can do to improve the plugin:

  • use DokuWiki's msg() function to display any message, to
    accommodate better with dokuwiki template
  • rework Input form design, to emphasize that admin must specify
    Lang-code that he want to keep, not delete
  • separate longer text in lang.php to text file for easing
    translation to other languages.

It is glad if you like my work for the plugin, even I could not
complete german language files.


    You can merge this Pull Request by running

git pull https://github.com/ssahara/dw-plugin-langdelete dev

Or view, comment on, or merge it at:

#2

    Commit Summary


Reply to this email directly or view it on GitHub
#2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants