Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all ESLint rules #7

Closed
rwu823 opened this issue Nov 11, 2018 · 5 comments
Closed

Fix all ESLint rules #7

rwu823 opened this issue Nov 11, 2018 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@rwu823
Copy link
Contributor

rwu823 commented Nov 11, 2018

Once #6 PR is merged. we'll get many errors. like this, 😅

image

So anyone can help to fix it?

cc @cjk-halodule

@rwu823
Copy link
Contributor Author

rwu823 commented Nov 11, 2018

Tips: you can run eslint --fix to fix most errors.

@rwu823 rwu823 added the help wanted Extra attention is needed label Nov 11, 2018
@ghost ghost assigned trashmai and ghost Nov 11, 2018
@ghost
Copy link

ghost commented Nov 11, 2018

我對 unexpected function expression 有點怕怕的。我想等 #8 完成後再來跑比較保險?

@rwu823
Copy link
Contributor Author

rwu823 commented Nov 11, 2018

That's OK

@ghost
Copy link

ghost commented Nov 12, 2018

Under this project, I've done

$git pull
$npm install -g eslint
$eslint --fix

But it shows $eslint --help
Did I miss anything?

@ghost ghost added this to To do in API v0 development Nov 13, 2018
@ghost ghost assigned dca, trashmai and ghost and unassigned trashmai, ghost and dca Nov 13, 2018
@ghost ghost moved this from To do to Done in API v0 development Nov 15, 2018
@ghost ghost moved this from Done to To do in API v0 development Nov 20, 2018
@rwu823
Copy link
Contributor Author

rwu823 commented Nov 30, 2018

it is done.

@rwu823 rwu823 closed this as completed Nov 30, 2018
API v0 development automation moved this from To do to Done Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
No open projects
Development

No branches or pull requests

3 participants