Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint + precommit hooks #6

Merged
2 commits merged into from
Nov 11, 2018
Merged

eslint + precommit hooks #6

2 commits merged into from
Nov 11, 2018

Conversation

rwu823
Copy link
Contributor

@rwu823 rwu823 commented Nov 11, 2018

Why?

Currently this code base didn't respect ESLint rules.

Fixs

  • Extends Airbnb (The most popular rules in JS Community)
  • Add pre-commit hooks (each commit will get fixed)

@ghost ghost merged commit 4b00ed0 into master Nov 11, 2018
@rwu823 rwu823 deleted the feature/eslint-base branch November 11, 2018 01:08
@rwu823 rwu823 mentioned this pull request Nov 11, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant