Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: log command extended with "--ignore" options #395

Merged
merged 4 commits into from
Sep 28, 2020

Conversation

gnanet
Copy link
Contributor

@gnanet gnanet commented Sep 17, 2020

@jmaupetit as promised here is the separated PR for log command

You can now limit the log to ignore a project or a tag using the `--ignore-project` and `--ignore-tag` options.
They can be specified several times each to ignore multiple projects or tags.

…t command already allows

    You can now limit the log to ignore a project or a tag using the `--ignore-project` and `--ignore-tag` options.
    They can be specified several times each to ignore multiple projects or tags.
    report command already allows igonre project or tag, this adds the same to
    filtered_frames = watson.frames.filter( ...
    You can now limit the log to ignore a project or a tag using the `--ignore-project` and `--ignore-tag` options.
    They can be specified several times each to ignore multiple projects or tags.
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Can you update the documentation and fill the CHANGELOG? 🙏

@gnanet
Copy link
Contributor Author

gnanet commented Sep 21, 2020

@jmaupetit i want to be sure, so i ask:

update the documentation

Is this is the part created with gen-cli-docs.py and mkdocs?

and fill the CHANGELOG?

If you mean to add my change the content of the CHANGELOG.md in some similar form:

## [YOU-TELL-ME-THE-VERSION] - 2020-09-21

### Added

- Log output can now be filtered to exclude projects and tags via ... (#395)

 * Add two options to ignore a project or a tag when requesting a log, in the same way you can do it with report (see TailorDev#288).
@gnanet
Copy link
Contributor Author

gnanet commented Sep 21, 2020

@jmaupetit

  1. Adding a non-versioned entry to the CHANGELOG was hopefully done right
  2. But updating the docs/user-guide/commands.md after doing the make env + make install-dev + scripts/gen-cli-docs.py the changes in that file were not only my parts, but it seemed to include fixes to parameter types, typo's, etc, they look reasonable anyway.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Julien Maupetit <jmaupetit@users.noreply.github.com>
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmaupetit jmaupetit merged commit 63dc317 into TailorDev:master Sep 28, 2020
jmaupetit added a commit that referenced this pull request Mar 19, 2021
Added:

- The `log` command output can now be filtered to exclude projects and
  tags via `--ignore-project` and `--ignore-tag` (#395)
- Python 3.8 support (#402)
- Python 3.9 support (#402)
- Support for the TZ environment variable to specify the local time zone
  (#391)

Changed:

- Upgrade to major arrow release 1.0.0 (#407)

Fixed:

- Zsh completion (#379)

Removed:

- Python 2.7 support (#305).
- Python 3.5 support (#407).
@jmaupetit jmaupetit mentioned this pull request Mar 19, 2021
jmaupetit added a commit that referenced this pull request Mar 19, 2021
Added:

- The `log` command output can now be filtered to exclude projects and
  tags via `--ignore-project` and `--ignore-tag` (#395)
- Python 3.8 support (#402)
- Python 3.9 support (#402)
- Support for the TZ environment variable to specify the local time zone
  (#391)

Changed:

- Upgrade to major arrow release 1.0.0 (#407)

Fixed:

- Zsh completion (#379)

Removed:

- Python 2.7 support (#305).
- Python 3.5 support (#407).
veganjay pushed a commit to veganjay/Watson that referenced this pull request May 15, 2021
Added:

- The `log` command output can now be filtered to exclude projects and
  tags via `--ignore-project` and `--ignore-tag` (TailorDev#395)
- Python 3.8 support (TailorDev#402)
- Python 3.9 support (TailorDev#402)
- Support for the TZ environment variable to specify the local time zone
  (TailorDev#391)

Changed:

- Upgrade to major arrow release 1.0.0 (TailorDev#407)

Fixed:

- Zsh completion (TailorDev#379)

Removed:

- Python 2.7 support (TailorDev#305).
- Python 3.5 support (TailorDev#407).
samtx added a commit to samtx/Watson that referenced this pull request Apr 17, 2022
* Resolve Issue TailorDev#407: Migrate to arrow 1.0.0

- requirements.txt: specify arrow==1.00
- frames.py, fullmoon.py, watson.py: change "timestamp" to
  "int_timestamp"

* Resolve Issue TailorDev#407: Migrate to arrow 1.0.0

- cli.py: change "date.tzinfo = tz.tzlocal()" to "date.replace(tzinfo=tz.tzlocal())"

* Update requirements.txt

This makes sense, especially given that arrow is already up to 1.0.2

Co-authored-by: Julien Maupetit <jmaupetit@users.noreply.github.com>

* Resolve Issue TailorDev#407: Migrate to arrow 1.0.0

- watson.cli.py: use date = date.replace(tzinfo=tz.tzlocal())
  (date.replace does not modify the existing object)

* Resolve Issue TailorDev#407: Migrate to arrow 1.0.0

Update unit test cases:

- tests/test_cli.py: replace arrow.arrow.datetime with arrow.arrow.dt_datetime
- tests/test_watson.py: replace .timestamp with .int_timestamp

* Resolve Issue TailorDev#407: Migrate to arrow 1.0.0

- .travis.yml: remove python 3.5
- setup.py: require python >= 3.6
- CHANGELOG.md: mention arrow upgrade and drop of python 3.5 support

* Update watson.zsh-completion

fix: autocompletion won't work with zsh 5.8

* Use TZ environment variable to set the timezone (TailorDev#411)

Watson did not have a way to set the timezone, other than what the system used.
In UNIX you can set the TZ variable to represent the timezone you want your
programs to respect.

* Bump release to 2.0.0

Added:

- The `log` command output can now be filtered to exclude projects and
  tags via `--ignore-project` and `--ignore-tag` (TailorDev#395)
- Python 3.8 support (TailorDev#402)
- Python 3.9 support (TailorDev#402)
- Support for the TZ environment variable to specify the local time zone
  (TailorDev#391)

Changed:

- Upgrade to major arrow release 1.0.0 (TailorDev#407)

Fixed:

- Zsh completion (TailorDev#379)

Removed:

- Python 2.7 support (TailorDev#305).
- Python 3.5 support (TailorDev#407).

* Fix year in 2.0.0 release

Believe it or not its 2021!

* Gracefully handle empty stop time (TailorDev#418)

Recent arrow library update broke the current frame edition.

* Bump release to 2.0.1

Fixed:

- Ability to `edit` the current frame (TailorDev#418)

* Add 'notes' field to frames.

This is a large commit that adds the following:

1. Syntax: `watson stop --notes "some additional information"`.
2. Print only non-empty notes in log.
3. Always pass id to `new_frame` so that the length of array with/without
   notes doesn't cause ambiguity.
4. Print a warning message and the existing note if overwriting a note.
5. Print notes in report.

Primary work here was done by the following people:

Co-authored-by: Tristan Pratt <prat0088@gmail.com>
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>

* notes: Print notes in `watson log`.

* notes: Fix tests.

* Set requirements for click >= 8.0 and rename autocompletion parameter to shell_complete. Remove 'multiple' paramater on reporting option

Co-authored-by: Jason Youzwak <jyouzwak@perspectalabs.com>
Co-authored-by: veganjay <veganjay@gmail.com>
Co-authored-by: Julien Maupetit <jmaupetit@users.noreply.github.com>
Co-authored-by: Nikolay Shkrylev <snnwolf@users.noreply.github.com>
Co-authored-by: Eddie Ash <cazador481@users.noreply.github.com>
Co-authored-by: Julien Maupetit <julien@maupetit.net>
Co-authored-by: Matthew Barry <komputerwiz.matt@gmail.com>
Co-authored-by: Rohitt Vashishtha <aero31aero@gmail.com>
Co-authored-by: Tristan Pratt <prat0088@gmail.com>
Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants