Fix flake8 E722 rule

td_biblio/models.py

@@ -48,14 +48,21 @@ def get_formatted_name(self):
     def _set_user(self):
         """Look for local django user based on human name"""
 
+        if '' in (self.last_name, self.first_name):
+            return
+
+        self._set_first_initial()
+
         User = get_user_model()
         try:
             self.user = User.objects.get(
                 models.Q(last_name__iexact=self.last_name),
                 models.Q(first_name__iexact=self.first_name) |
                 models.Q(first_name__istartswith=self.first_initial[0])
             )
-        except:
+        except User.DoesNotExist:
+            pass
+        except User.MultipleObjectsReturned:
             pass
 
 

td_biblio/utils/loaders.py

@@ -181,7 +181,7 @@ def to_record(self, input):
         # Check if month is numerical or not
         try:
             int(pub_date['month'])
-        except:
+        except ValueError:
             pub_date['month'] = strptime(pub_date['month'], '%b').tm_mon
         # Convert date fields to integers
         pub_date = dict(
@@ -268,7 +268,7 @@ def load_records(self, PMIDs=None):
         for entry in entries:
             try:
                 record = self.to_record(entry)
-            except:
+            except Exception:
                 e, v, tb = sys.exc_info()
                 msg = _(
                     "An error occured while loading the following PMID: {}. "
@@ -344,7 +344,7 @@ def load_records(self, DOIs=None):
             data = json.loads(r)
             try:
                 record = self.to_record(data)
-            except:
+            except Exception:
                 e, v, tb = sys.exc_info()
                 msg = _(
                     "An error occured while loading the following DOI: {}. "

td_biblio/views.py

@@ -57,23 +57,23 @@ def get(self, request, *args, **kwargs):
         # Is it an integer?
         try:
             self.current_publication_date = datetime.date(int(year), 1, 1)
-        except:
+        except TypeError:
             self.current_publication_date = None
 
         # -- Publication author
         author = self.request.GET.get('author', None)
         # Is it an integer?
         try:
             self.current_publication_author = int(author)
-        except:
+        except TypeError:
             self.current_publication_author = None
 
         # -- Publication collection
         collection = self.request.GET.get('collection', None)
         # Is it an integer?
         try:
             self.current_publication_collection = int(collection)
-        except:
+        except TypeError:
             self.current_publication_collection = None
 
         return super(EntryListView, self).get(request, *args, **kwargs)