Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass variable values to a shell command’s stdin #283

Closed
4 tasks done
Taitava opened this issue Nov 5, 2022 Discussed in #89 · 1 comment
Closed
4 tasks done

Pass variable values to a shell command’s stdin #283

Taitava opened this issue Nov 5, 2022 Discussed in #89 · 1 comment
Labels
enhancement New feature or improving change
Milestone
0.18.0

Comments

@Taitava
Copy link
Owner

Taitava commented Nov 5, 2022 •
edited
Loading

Discussed in #89

(Edit: I removed ideas-from-others label as I only plan to use that label in discussions, not in issues, although this idea is from another person.)

TODO:

  • Add to CHANGELOG.
  • Write documentation.
  • Write tests.
    • Test suite: Find out why Test {{file content}} / Test {{note content}} miss linebreaks in output. At least on Windows PowerShell. Edit: They were missing on Linux, too, but fixed now.
@Taitava Taitava added the ideas-from-others Ideas requested by other users than Taitava. Helps prioritization. label Nov 5, 2022
@Taitava Taitava added this to the 0.18.0 milestone Nov 5, 2022
@Taitava Taitava added enhancement New feature or improving change and removed ideas-from-others Ideas requested by other users than Taitava. Helps prioritization. labels Nov 5, 2022
@Taitava Taitava mentioned this issue Nov 5, 2022
Closed
Taitava added a commit that referenced this issue Dec 4, 2022
@Taitava
CHANGELOG.md: #283
4d42599
Taitava added a commit that referenced this issue Dec 4, 2022
@Taitava
#283: Support for passing content to stdin.
0b8804f 
UI will be presented in next two commits.
Taitava added a commit that referenced this issue Dec 4, 2022
@Taitava
#283: CreateShellCommandFieldCore(): Extract logic for decorating mul…
301f86d 
…tiline textareas.

Textareas are still made separately, but the logic to make them grow and shrink based on the amount of content is moved to a separate function.
Taitava added a commit that referenced this issue Dec 4, 2022
@Taitava
#283: ExtraOptionsModal: UI for defining stdin content.
b4bf652
Taitava added a commit that referenced this issue Dec 4, 2022
@Taitava
#283: ExtraOptionsModal: Change stdin help texts.
c0d5516
Taitava added a commit to Taitava/obsidian-shellcommands-documentation that referenced this issue Dec 5, 2022
@Taitava
Pass variables to stdin.md
c9c81db 
Taitava/obsidian-shellcommands#283
Taitava added a commit that referenced this issue Dec 5, 2022
@Taitava
#283: TShellCommand.createParsingProcess(): Variables used in stdin s…
65b0bcf 
…hould be escaped.
Taitava added a commit that referenced this issue Dec 5, 2022
@Taitava
#283: ExtraOptionsModal.tabGeneral(): Rename 'Pass variables to stdin'.
1ffd30f
Taitava added a commit that referenced this issue Dec 23, 2022
@Taitava
Merge branch '#283-stdin' into 0.18.0
3d5213f 
# Conflicts:
#	src/settings/ExtraOptionsModal.ts
Taitava added a commit that referenced this issue Dec 23, 2022
@Taitava
#283, #298: Increase settings version to 0.18.0.
976a6b3
Taitava added a commit to Taitava/obsidian-shellcommands-test-suite that referenced this issue Dec 23, 2022
@Taitava
Template: Make "Test {{file content}}" and "Test {{note content}}" us…
8b82e6a 
…e stdin.

Taitava/obsidian-shellcommands#283
Taitava added a commit that referenced this issue Jan 1, 2023
@Taitava
#283: TShellCommand.createParsingProcess(): Prevent escaping stdin co…
f522892 
…ntent.

Reverts 65b0bcf, but does not use the old comment "shells won't interpret stdin as executable commands" which was misleading.
Taitava added a commit that referenced this issue Jan 1, 2023
@Taitava
#283: ExtraOptionsModal.tabGeneral(): Stdin field: Add 'experimental'…
65b5c0e 
… note.
@Taitava
Copy link
Owner Author

Taitava commented Jan 8, 2023

I forgot to close this issue. This was released in 0.18.0 a couple of days ago.

@Taitava Taitava closed this as completed Jan 8, 2023
Taitava added a commit to Taitava/obsidian-shellcommands-documentation that referenced this issue Feb 13, 2023
@Taitava
Index.md: Fix stdin link.
ac067d7 
Re: c9c81db

Taitava/obsidian-shellcommands#283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improving change
Projects
None yet
Milestone
0.18.0
Development

No branches or pull requests
1 participant
@Taitava