Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/filtering #9

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

TomWeps
Copy link

@TomWeps TomWeps commented May 14, 2019

I noticed, when mapping grows then it is harder to work on the mappings.
I added row filtering ( simplified excel kind), which allows to focus only on some groups of records. This feature is not perfect (how it looks etc ), nonetheless, it significantly improved my work. If I have more time, perhaps I'll try to improve it later.

cmdr_withFiltering

@pestrela
Copy link

looks cool!

@pestrela
Copy link

@TomWeps do you have a release I can test with your feature?

@pestrela
Copy link

pestrela commented Dec 17, 2019

@TomWeps your grep-style filtering feature is really useful!
cmdr filtering

I've now added some dev docs to my repo, incluiding how to build the code, a changelog and the features I'm working right now
https://github.com/pestrela/cmdr/tree/master/docs/development

@pestrela
Copy link

pestrela commented Dec 18, 2019

hi Tom
I'm adding a clear filtering feature to your WPF work.

I'm already able to trigger my own new function inside cmdr.WpfControls.CustomDataGrid, but I'm stuck on how to find the textboxes to call clear() on them

Can you please give me a pointer on how to do this?

@TomWeps
Copy link
Author

TomWeps commented Dec 18, 2019

Hi @pestrela ,
Thank you for your "warm words" and I'm sorry for delay in my resposne.
I'm glad, that someone is eager to support this project. It looks like the offical / orignal author doesn't respond at all.

I do not remember well the source code. When I have time I will take a look. Could you please descirbe little bit more, what you are trying to achive ? Single button, which will clear all fiters ?
Create a Feature Branch in your repo, so I will be able to see what you already have/where you stacked.

@pestrela
Copy link

pestrela commented Dec 19, 2019

Hi Tom,
Thanks for your availability.

I was struggling to find the Textboxes starting from the CustomDataGrid. But there were too many objects/references etc.
Then I saw a simple trick in a comment: just add them to a list as we consume OnTextChanged.

I've now recoded this with a dictionary to avoid memory leaks.
pestrela@f64fbbf

@pestrela
Copy link

pestrela commented Dec 19, 2019

You can track the changlog in this link. For example I just finished support for the new TP3 commands.
https://github.com/pestrela/cmdr/blob/master/docs/development/Change_Log.md

Feel free to join this effort. I will be working with CMDR this holiday season, trying to remove my major pain points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants