Fix superfluous exception when socket read returns less than the requ… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ested number of bytes
|
Thank you very much for your finding the bug. |
TakahikoKawasaki
pushed a commit
that referenced
this pull request
May 19, 2015
Fix superfluous exception when socket read returns less than the requ…
|
I'll release a new version (1.4) soon. |
|
Version 1.4 was released. (nv-websocket-client|1.4|jar) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ested number of bytes
This problem was observed when using the implementation on Motorola MotoG and MotoE phones. The initial call to read(buffer, 0, length) with a 3-byte request would only return 1 byte. This would result in a WebSocketException and closing of the socket. However, a subsequent call to read() would return the remaining bytes.