add: type OGPFetchResult

TakahiroHimi · Oct 16, 2021 · fffe4e7 · fffe4e7
1 parent 66032dd
commit fffe4e7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ogp-fetcher",
-  "version": "1.3.0",
+  "version": "1.4.0",
   "description": "Library to fetch OGB",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

diff --git a/src/fetchOgp.ts b/src/fetchOgp.ts
@@ -1,12 +1,19 @@
 import axios, { AxiosRequestHeaders } from "axios";
 import { JSDOM } from "jsdom";
 
+export type OGPFetchResult = {
+  url: string;
+  [key: string]: string;
+}[];
+
 /**
  *
  * @param targetUrls fetch target url list
  * @returns ogp list
  */
-export const fetchOgp = async (targetUrls: string[]) => {
+export const fetchOgp = async (
+  targetUrls: string[]
+): Promise<OGPFetchResult> => {
   const headers: AxiosRequestHeaders = { "User-Agent": "bot" };
 
   const fetches = targetUrls.map((url) => {
@@ -57,7 +64,7 @@ export const parseOgp = (htmlList: string[]) => {
  */
 export const ogpFilter = (metaElements: NodeListOf<HTMLMetaElement>) => {
   const ogps = [...Array(metaElements.length).keys()].reduce(
-    (prev: { [key: string]: string }, i) => {
+    (prev: { [property: string]: string }, i) => {
       const property = metaElements.item(i).getAttribute("property")?.trim();
       if (!property) return prev;
       const content = metaElements.item(i).getAttribute("content");