Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Added a method to set/get a Handlebars instance #6

Closed
wants to merge 7 commits into from
Closed

Added a method to set/get a Handlebars instance #6

wants to merge 7 commits into from

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Mar 26, 2015

This also changes the API, to get the default Handlebars one has to call the using method that will return either the dependency or the previously set instance using the use method.

Maybe you like this idea. It's much more handy for me at least to use it like that.

Actually, it would be great to remove the handlebars dependency and set it explicitly:

var staticHbs = require('gulp-static-handlebars')(Handlebars);

Sorry, it's not a perfect PR, and also I could not run the tests due to some errors. Let me know what you think about changing the API like this.

@coveralls
Copy link

Coverage Status

Coverage decreased (-38.82%) to 61.18% when pulling ded51f9 on OrKoN:master into d033646 on TakenPilot:master.

@TakenPilot
Copy link
Owner

Hmm, I think the idea has merit. Could you squash your commits to something atomic?

Are you trying to insert handlebars because of the new version 3? We could just upgrade to version 3, since the dependency badge is already complaining about that. : )

@TakenPilot
Copy link
Owner

What I mean by atomic:

We could also change the handlebars requirement to use >= instead of ~ to allow any handlebars version greater than the current one.

Like this: #7

@OrKoN OrKoN closed this Mar 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants