[MIRROR] [MDB IGNORE] Adds a stamp sound effect when stamping papers #3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request This pull request adds a .ogg file of a stamp stamping a paper, a playsound function for stamping a paper, stamping a paper while blind, and stamping yourself in the head to commit suicide. In addition, it modifies the attributions.txt file to include credits to the creator of the stamp noise. ## Why It's Good For The Game Most item interactions tend to have a sound effect that plays. Putting most items down, throwing them, cutting certain items with the knife, scanning bounty cubes, putting a destination tag on a package, etc. all play sounds, which makes it a bit odd that stamping papers doesn't. This PR adds audio feedback to stamping papers. https://user-images.githubusercontent.com/45489195/210032424-d3168a16-3d4b-47d3-95f3-75a1d3a6aac9.mp4 ## Changelog Stamping paper now makes noise. :cl: soundadd: Added a new sound for stamping papers with a stamp. On an unrelated note, there are reports of stamp-based suicides becoming more noisy. /:cl:
keywordlabeler
bot
added
Feature
TaleStationBot
added a commit
that referenced
this pull request
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: tgstation/tgstation#72367
About The Pull Request
This pull request adds a .ogg file of a stamp stamping a paper, a playsound function for stamping a paper, stamping a paper while blind, and stamping yourself in the head to commit suicide.
In addition, it modifies the attributions.txt file to include credits to the creator of the stamp noise.
Why It's Good For The Game
Most item interactions tend to have a sound effect that plays. Putting most items down, throwing them, cutting certain items with the knife, scanning bounty cubes, putting a destination tag on a package, etc. all play sounds, which makes it a bit odd that stamping papers doesn't. This PR adds audio feedback to stamping papers.
StampDemo.mp4
Changelog
Stamping paper now makes noise.
馃啈
soundadd: Added a new sound for stamping papers with a stamp. On an unrelated note, there are reports of stamp-based suicides becoming more noisy.
/:cl: