chore(containers): remove Form from default export #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jare-talend
reviewed
Feb 1, 2018
| @@ -48,7 +47,6 @@ export { | |||
| Drawer, | |||
| DeleteResource, | |||
| FilterBar, | |||
| Form, | |||
There was a problem hiding this comment.
just indicating on the PR there is a breaking change.
jsomsanith-tlnd
suggested changes
Feb 1, 2018
romainseb
changed the title
jsomsanith-tlnd
approved these changes
Feb 2, 2018
jsomsanith-tlnd
changed the title
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
With Form container in default export, we must have form as dependency on the project that import containers
What is the chosen solution to this problem?
Remove Form from default export and import it à la lodash when you need it
Please check if the PR fulfills these requirements
[x] This PR introduces a breaking change