-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DeleteResource): Add wording & i18n #1243
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7968034
feat(containers/delete-resource): add some label
romainseb 5d6ea9d
make it work
romainseb b8be2cd
update tests
romainseb 070dee9
test(ci): update code style outputs
0ae3b65
wip
romainseb 845de76
update tests
romainseb 6d5c414
Merge branch 'master' into sromain/delete-resource-text
romainseb f6ffe05
test(ci): update code style outputs
39ec6c3
add eslint ignore
romainseb 482a80b
test(ci): update code style outputs
b2b40d2
Merge branch 'master' into sromain/delete-resource-text
romainseb 17951a7
add some doc
romainseb 0a7435e
Merge branch 'master' into sromain/delete-resource-text
jsomsanith-tlnd dcbafa7
Merge branch 'master' into sromain/delete-resource-text
romainseb c6daf18
fix lints
romainseb e4f63f5
test(ci): update code style outputs
cd6b612
Merge branch 'master' into sromain/delete-resource-text
romainseb 192e767
update root package.json
c327be6
fix npm scripts
jsomsanith-tlnd c84845f
Merge branch 'master' into sromain/delete-resource-text
romainseb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 things on i18n :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsomsanith The next major version of i18next-parser will be compatible with Trans. I work on i18n on the next sprint so I like to update this package to manage it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, i think this is still the best way to get the translations with html markup.
There is another issue currently, as the Trans component manage to make it work the count attribute but the "context" attribute to declare male or female translation is not working as it is. I try to make a PR on this point in react-i18next ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json
like the others, so thatyarn extract-i18n
extract all packages translations in a single folder. Take a look at root npm scripts