feat(CMF/TUI-305): omitCMFProps is the default now #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is a fork of fontgen-loader (not maintained and has security issues
1 similar comment
jsomsanith-tlnd
approved these changes
Dec 21, 2018
packages/cmf/src/cmfConnect.js
Outdated
| withComponentRegistry = false, | ||
| withDispatch = false, | ||
| withDispatchActionCreator = false, | ||
| withComponentId = false, | ||
| ...rest | ||
| } = {}) { | ||
| const propsToOmit = []; | ||
| if (omitCMFProps) { | ||
| if (omitCMFProps === undefined || omitCMFProps === true) { |
There was a problem hiding this comment.
You can replace this double check by just if (omitCMFProps) + default value omitCMFProps = true
1 similar comment
1 similar comment
jsomsanith-tlnd
deleted the
jmfrancois/feat/cmf/omit-props-default-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
As we have announce with #1749 winter is coming.
What is the chosen solution to this problem?
breaking change, put the omitCMFProps by default to true.
Add a warning once and per component if omitCMFProps is set.
Please check if the PR fulfills these requirements
[x] This PR introduces a breaking change